upcoming: [M3-8420] – Add conditionally-displayed reboot notice on Volume Create page#10868
Conversation
…ow if user selects a linode that does not support BSE
dwiley-akamai
added
the
Block Storage Encryption (BSE)
…d as well, and disable Create button when that notice is being displayed
dwiley-akamai
requested review from
AzureLatte,
cpathipa and
hkhalil-akamai
and removed request for
a team
…t notice to Volume Create page
|
Coverage Report: ✅ |
cpathipa
left a comment
cpathipa
left a comment
There was a problem hiding this comment.
LGTM! Confirming on the functionality and client libraries notice in Volume create flow.
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Confirmed the reboot notice showed and create button disabled once the checkbox was checked for a linode without the bse capability, and that the spacing and alignment looks good. With the feature flag off, no notice or disabled button, as expected.
|
|
||
| // @TODO BSE: once BSE is fully rolled out, check for the notice (selected linode doesn't have | ||
| // blockstorage_encryption capability + user checked "Encrypt Volume" checkbox) instead of the absence of it | ||
| cy.findByText(CLIENT_LIBRARY_UPDATE_COPY).should('not.exist'); |
There was a problem hiding this comment.
When manually testing, rebooting a linode without the bse capability didn't result in an upgraded qemu version/bse capability for me - not sure if that's expected in dev. I might have missed it, but wasn't seeing anywhere in tests where we were confirming that a user with a bse capability on the linode would no longer see the checkbox. Did we want to confirm this?
There was a problem hiding this comment.
Raised the reboot --> upgrade question in the project channel, not sure if that is fully in place yet.
Added test coverage for the case where the linode supports BSE
|
|
||
| const { data: linode } = useLinodeQuery( | ||
| linode_id ?? -1, | ||
| isBlockStorageEncryptionFeatureEnabled |
There was a problem hiding this comment.
Late to this PR, but noticed a minor issue that can be resolved in a later change:
To prevent an API call for linodes/instances/-1
| isBlockStorageEncryptionFeatureEnabled | |
| isBlockStorageEncryptionFeatureEnabled && linode_id !== null |
5 participants
Description 📝
Add conditionally-displayed reboot notice on Volume Create page
Target release date 🗓️
9/16/24
Preview 📷
How to test 🧪
Prerequisites
Point at the dev environment with the
blockstorage-encryptiontag on your account.Verification steps
Pointing at the dev environment:
With the BSE feature flag off, you should not see a client library update reboot notice regardless of which linode you select.
With the BSE feature flag on, if you select a linode that does not have the
blockstorage_encryptioncapability & check the "Encrypt Volume" checkbox, you should see the client library update reboot notice below the Linode dropdown. The "Create Volume" button should also be disabled.Confirm the alignment of the Linode & Config dropdowns look good in both cases, and across viewport widths (they stack in mobile view)
As an Author I have considered 🤔