Skip to content

feat: [M3-8178] - Add SelectableTableRow Story#10870

Merged
jaalah-akamai merged 2 commits intolinode:developfrom
pmakode-akamai:M3-8178-add-selectabletablerow-story
Sep 5, 2024
Merged

feat: [M3-8178] - Add SelectableTableRow Story#10870
jaalah-akamai merged 2 commits intolinode:developfrom
pmakode-akamai:M3-8178-add-selectabletablerow-story

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Sep 3, 2024

Description 📝

Add SelectableTableRow Story to Storybook

Changes 🔄

  • Add SelectableTableRow Story

Target release date 🗓️

9/16

How to test 🧪

Verification steps

  • Run yarn storybook to test locally

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai self-assigned this Sep 3, 2024
@pmakode-akamai pmakode-akamai changed the title Add story for SelectableTableRow component feat: [M3-8178] - Add SelectableTableRow story Sep 3, 2024
@pmakode-akamai pmakode-akamai changed the title feat: [M3-8178] - Add SelectableTableRow story feat: [M3-8178] - Add SelectableTableRow Story Sep 3, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review September 3, 2024 12:34
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner September 3, 2024 12:34
@pmakode-akamai pmakode-akamai requested review from coliu-akamai and jaalah-akamai and removed request for a team September 3, 2024 12:34
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 🎉

Here or in another ticket, could we add unit tests for the SelectableTableRow component?

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 3, 2024
@pmakode-akamai
Copy link
Contributor Author

pmakode-akamai commented Sep 4, 2024

great work! 🎉

Here or in another ticket, could we add unit tests for the SelectableTableRow component?

Thanks, @coliu-akamai 🙂.

We will have another ticket (M3-8518) for adding unit test cases for this component.

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation and removed Add'tl Approval Needed Waiting on another approval! Documentation Improving / adding to our documentation labels Sep 5, 2024
@jaalah-akamai jaalah-akamai merged commit 5d82a23 into linode:develop Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Storybook

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants