refactor: [M3-8496] - Remove Placement Group flag and underlying logic#10877
Merged
abailly-akamai merged 3 commits intolinode:developfrom Sep 6, 2024
Merged
refactor: [M3-8496] - Remove Placement Group flag and underlying logic#10877abailly-akamai merged 3 commits intolinode:developfrom
abailly-akamai merged 3 commits intolinode:developfrom
Conversation
abailly-akamai
requested review from
carrillo-erik,
jdamore-linode and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
carrillo-erik
approved these changes
Sep 4, 2024
Contributor
carrillo-erik
left a comment
carrillo-erik
left a comment
There was a problem hiding this comment.
Thanks for taking care of this and preventing stale code from remaining in the project. ✅
carrillo-erik
suggested changes
Sep 4, 2024
Contributor
carrillo-erik
left a comment
carrillo-erik
left a comment
There was a problem hiding this comment.
These are the culprits causing the failures in the PR. Removing these should do the trick.
packages/manager/cypress/e2e/core/placementGroups/placement-groups-navigation.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/placementGroups/placement-groups-navigation.spec.ts
Outdated
Show resolved
Hide resolved
mjac0bs
reviewed
Sep 4, 2024
packages/manager/cypress/e2e/core/placementGroups/placement-groups-navigation.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodeCreatev2/Details/Details.test.tsx
Outdated
Show resolved
Hide resolved
mjac0bs
reviewed
Sep 4, 2024
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
(Found a couple more comments to clean up in the tests, as well.)
Contributor
There was a problem hiding this comment.
Suggested change
| // Mock the VM Placement Groups feature flag to be enabled for each test in this block. |
Comment on lines
49
to
50
Contributor
There was a problem hiding this comment.
Suggested change
| // Mock the VM Placement Groups feature flag to be enabled for each test in this block. | |
| // TODO Remove these mocks when `placementGroups` feature flag is retired. |
abailly-akamai
force-pushed
the
M3-8496
branch
from
39ab57d to
13e0517
Compare
mjac0bs
approved these changes
Sep 5, 2024
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks, this should be set now! 🚢
jaalah-akamai
added
Approved
carrillo-erik
approved these changes
Sep 5, 2024
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Update CM codebase to remove
placementGroupsflag logic.This is should bring no changes to the feature nor introduce any regressions
Changes 🔄
List any change relevant to the reviewer.
How to test 🧪
Prerequisites
Verification steps
As an Author I have considered 🤔
Check all that apply