test: [M3-8471] - Allow Cypress region selection to work with Gecko options improvements#10888
Merged
jdamore-linode merged 2 commits intolinode:developfrom Sep 5, 2024
Conversation
|
Coverage Report: ✅ |
Contributor
Contributor
|
I got it to fail on |
jaalah-akamai
approved these changes
Sep 5, 2024
Contributor
jaalah-akamai
left a comment
There was a problem hiding this comment.
✅ Passes regardless if gecko flag is on or off
Contributor
Author
|
Ah sorry @jaalah-akamai, forgot to mention the feature flag! I had just manually edited the components to force them into their Gecko state while I was developing this because I can't add the account tag to my test account (for non-technical reasons) |
hana-akamai
approved these changes
Sep 5, 2024
AzureLatte
approved these changes
Sep 5, 2024
This was referenced Sep 13, 2024
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
This updates the
ui.regionSelect.findItemById()andui.regionSelect.findItemByLabel()helpers so that they work when the upcoming Gecko changes are enabled and disabled. Previously, these helpers would fail to select a region when Gecko is enabled due to the layout improvements made to the region selection options.Changes 🔄
ui.regionSelect.findItemById()andui.regionSelect.findItemByLabel()work with and without GeckoTarget release date 🗓️
N/A
How to test 🧪
Prerequisites:
Use a test account with Gecko enabled and set
MANAGER_OAUTHin.envto a PAT belonging to the account, and run Cloud against a LaunchDarkly environment where the Gecko feature flag is enabled.Reproduction steps
On
develop:yarn && yarn build && yarn start:manager:ciyarn cy:debuggdpr-agreement.spec.tsspec and run itVerification steps
On this branch:
yarn && yarn build && yarn start:manager:ciyarn cy:debuggdpr-agreement.spec.tsspec and run itAs an Author I have considered 🤔
Check all that apply