fix: [M3-8529] - Weblish line wrapping#10893
Merged
abailly-akamai merged 2 commits intolinode:developfrom Sep 6, 2024
Merged
Conversation
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Sep 5, 2024
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks much better! Line wrapping and cursor position is working as expected now 🎉
Screen.Recording.2024-09-05.at.12.19.55.PM.mov
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
When working on file edits in Weblish, current line wrapping makes it impossible to edit certain lines because of the way our columns are set up. Weblish is visually showing additional characters past 80 columns on the same line while the cursor behaves as though the line is soft wrapped.
Changes 🔄
colsto80to match default LISH over ssh behaviorTarget release date 🗓️
9/16/2024
Preview 📷
Screen.Recording.2024-09-05.at.10.50.55.mov
Screen.Recording.2024-09-05.at.10.49.52.mov
How to test 🧪
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply