fix: [M3-7916] - Typo with toast success notification for updating Reverse DNS by coliu-akamai · Pull Request #10895 · linode/manager

coliu-akamai · 2024-09-05T17:18:18Z

Description 📝

fix typo with toast success notification when updating reverse DNS

Changes 🔄

fix typo
add e2e test to confirm typo is fixed
added some unit tests
other small cleanup

Target release date 🗓️

n/a

Preview 📷

Before	After

How to test 🧪

Verification steps

yarn cy:run -s cypress/e2e/core/linodes/linode-network.spec.ts
Confirm toast says RDNS when updating RDNS in a Linode's network tab
Confirm that RDNS drawer resets when opening/closing it

As an Author I have considered 🤔

Check all that apply

coliu-akamai · 2024-09-05T17:20:15Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/EditIPRDNSDrawer.tsx

+  const onExited = () => {
+    formik.resetForm();
+    reset();
+  };


see here for reasoning for this change

coliu-akamai · 2024-09-05T17:30:06Z

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

+          cy.findByText('Save')
+            .should('be.visible')
+            .should('be.enabled')
+            .click();


note - this test doesn't technically edit the RDNS, just clicks save to trigger and check the toast (I'm not too familiar with/sure how to edit the RDNS - would get an error each time)

That's actually useful context if we ever need to look back at this test after some time has passed. Maybe you can expand on that // click Save button comment to explain that we're only trying to trigger the toast and are intentionally not making any change to the form?

github-actions · 2024-09-05T17:51:05Z

Coverage Report: ✅
Base Coverage: 86.37%
Current Coverage: 86.37%

bnussman-akamai

Looks good! Lots of nice clean up and testing 🧼 🧪

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

jdamore-linode

Nice work @coliu-akamai, thanks! The new test looks great!

jdamore-linode · 2024-09-05T19:58:22Z

packages/manager/cypress/support/intercepts/linodes.ts

+/**
+ * Intercepts POST request to get a Linode Resize.


Nice catch, thanks for the fix! 😅

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

jdamore-linode · 2024-09-05T20:36:39Z

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

+          cy.findByText('Save')
+            .should('be.visible')
+            .should('be.enabled')
+            .click();


That's actually useful context if we ever need to look back at this test after some time has passed. Maybe you can expand on that // click Save button comment to explain that we're only trying to trigger the toast and are intentionally not making any change to the form?

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

coliu-akamai · 2024-09-05T21:18:53Z

ty for the feedback!! Just pushed up changes to use mocks + add context and cleanup

hkhalil-akamai

Great catch 👀 and thanks for adding unit and cypress tests!

hkhalil-akamai · 2024-09-09T22:06:07Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/EditIPRDNSDrawer.tsx

            loading: isPending,
            type: 'submit',
          }}
-          secondaryButtonProps={{ label: 'cancel', onClick: onClose }}


Nice catch!

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/EditIPRDNSDrawer.tsx

cpathipa

Nice work! confirming on the RDNS drawers functionality and tests.

jdamore-linode

Nice work @coliu-akamai! The new test is really solid -- I ran it on repeat 15 times and it passed each time. Thanks again!

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

coliu-akamai added 5 commits September 4, 2024 15:12

very quick typo fix, still need to write a bunch of tests

250355d

switch to onExited instead of using useEffect for resetting the drawer

2b851b6

starting tests

d8d4ce0

add unit tests for drawers

39fba63

e2e test for toast message (may switch to mocks)

c23b115

coliu-akamai added the Bug Fixes for regressions or bugs label Sep 5, 2024

coliu-akamai self-assigned this Sep 5, 2024

coliu-akamai commented Sep 5, 2024

View reviewed changes

coliu-akamai marked this pull request as ready for review September 5, 2024 17:20

coliu-akamai requested review from a team as code owners September 5, 2024 17:20

coliu-akamai requested review from cliu-akamai, cpathipa, hkhalil-akamai and jdamore-linode and removed request for a team September 5, 2024 17:20

changesets

5b09db6

coliu-akamai added the Ready for Review label Sep 5, 2024

coliu-akamai commented Sep 5, 2024

View reviewed changes

coliu-akamai changed the title ~~fix: [M3-7916] - Typo with Toast Success Notification For Updating Reverse DNS~~ fix: [M3-7916] - Typo with toast success notification for updating Reverse DNS Sep 5, 2024

bnussman-akamai approved these changes Sep 5, 2024

View reviewed changes

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts Outdated Show resolved Hide resolved

jdamore-linode approved these changes Sep 5, 2024

View reviewed changes

coliu-akamai added 2 commits September 5, 2024 17:03

use mocks instead

63f54a8

quick fixes

5120f62

coliu-akamai requested a review from jdamore-linode September 5, 2024 21:19

update comments

07f6843

coliu-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Sep 5, 2024

coliu-akamai removed the e2e Indicates that a PR touches Cypress tests in some way label Sep 5, 2024

hkhalil-akamai approved these changes Sep 9, 2024

View reviewed changes

fix helper text spacing @hkhalil-akamai

c4f66e4

mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 10, 2024

cpathipa approved these changes Sep 11, 2024

View reviewed changes

jdamore-linode approved these changes Sep 11, 2024

View reviewed changes

packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts Outdated Show resolved Hide resolved

coliu-akamai and others added 2 commits September 11, 2024 10:42

Update packages/manager/cypress/e2e/core/linodes/linode-network.spec.ts

4c8cdb1

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

remove unused import

656586c

coliu-akamai merged commit 51b1efa into linode:develop Sep 11, 2024

coliu-akamai deleted the m3-7916 branch September 11, 2024 15:11

This was referenced Sep 13, 2024

Release v1.128.0 - release → staging #10935

Merged

Release v1.128.0 - staging → master #10946

Merged

Conversation

coliu-akamai commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Verification steps

As an Author I have considered 🤔

Uh oh!

coliu-akamai Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

coliu-akamai Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdamore-linode Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bnussman-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jdamore-linode left a comment

Choose a reason for hiding this comment

Uh oh!

jdamore-linode Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jdamore-linode Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coliu-akamai commented Sep 5, 2024

Uh oh!

hkhalil-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

hkhalil-akamai Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

jdamore-linode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coliu-akamai commented Sep 5, 2024 •

edited

Loading

coliu-akamai Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading