fix: [M3-8553] - DisplayPrice story crash when Currency component's minimumFractionDigits is negative#10913
Merged
pmakode-akamai merged 3 commits intolinode:developfrom Sep 11, 2024
Conversation
minimumFractionDigits is NegativeminimumFractionDigits is Negative
…inimumFractionDigits is Negative
minimumFractionDigits is NegativeminimumFractionDigits is negative
|
Coverage Report: ✅ |
coliu-akamai
approved these changes
Sep 10, 2024
Contributor
coliu-akamai
left a comment
There was a problem hiding this comment.
looks great + thanks for adding additional test coverage! 🎉
hana-akamai
approved these changes
Sep 10, 2024
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
The Storybook for DisplayPrice is crashing when the
minimumFractionDigitsin the Currency component is set with a negative value.This PR addresses the issue by updating the Currency component to handle negative decimalPlaces props correctly. Specifically, it ensures that the
minimumFractionDigitsdefaults to 2 when thedecimalPlacesprop isnegativeorundefined.Changes 🔄
minimumFractionDigitsin the Currency component will now use the default value (2) whendecimalPlacesprop isnegativeorundefined.Target release date 🗓️
N/A
How to test 🧪
Reproduction steps
Verification steps
minimumFractionDigitsin the Currency component uses the default value (2) whendecimalPlacesprop isnegativeorundefined.As an Author I have considered 🤔
Check all that apply