fix: API Tokens Table Style Regression#10918
Merged
bnussman-akamai merged 4 commits intolinode:developfrom Sep 12, 2024
Merged
Conversation
bnussman-akamai
added
Bug
bnussman-akamai
requested review from
carrillo-erik and
coliu-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| Create a Personal Access Token | ||
| </Button> | ||
| )} | ||
| </Paper> |
Contributor
There was a problem hiding this comment.
Could we also add padding to the table to ensure it matches the styling of the other instances?
Reference
Member
Author
There was a problem hiding this comment.
We could consider that, but I think this is a different design pattern used here. It is also used in other places like Linode Details
harsh-akamai
approved these changes
Sep 12, 2024
bnussman-akamai
added
Add'tl Approval Needed
coliu-akamai
approved these changes
Sep 12, 2024
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
Confirmed style regression is gone (light/dark mode, small sizes) 🎉
One small thing I noticed after you showed the Linode storage tab - seems like the the table titles are closer to the left table border in API tokens than they are in the Linode storage tab?
coliu-akamai
added
Approved
Member
Author
|
Good catch @coliu-akamai I updated the padding to match |
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes a small style regression caused by design tokens 🎨 on the API tokens page
Preview 📷
How to test 🧪
As an Author I have considered 🤔