Skip to content

fix: [M3-8572] - Scrollbar showing briefly on Splash Screen#10922

Merged
bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai:M3-8572-fix-splash-screen-briefly-showing-scrollbar
Sep 16, 2024
Merged

fix: [M3-8572] - Scrollbar showing briefly on Splash Screen#10922
bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai:M3-8572-fix-splash-screen-briefly-showing-scrollbar

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 11, 2024

Description 📝

  • Fixes bug where a scrollbar would briefly show on the splash screen due to missing sr-only css class 📄

Preview 📷

Before After
Screen.Recording.2024-09-11.at.1.53.01.PM.mov
Screen.Recording.2024-09-11.at.1.52.35.PM.mov

How to test 🧪

  • Verify you don't see a scrollbar on the initial load of Cloud Manager
  • If you want the splash screen to stay open for testing, go to line 30 of App.tsx and force the splash screen to stay open

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Sep 11, 2024
@bnussman-akamai bnussman-akamai self-assigned this Sep 11, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 11, 2024 18:06
@bnussman-akamai bnussman-akamai requested review from carrillo-erik and hana-akamai and removed request for a team September 11, 2024 18:06
@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Coverage Report:
Base Coverage: 86.64%
Current Coverage: 86.64%

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 11, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 13, 2024
@bnussman-akamai bnussman-akamai merged commit 0ac8742 into linode:develop Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants