fix: [M3-8158] - Render the correct Avatar icon for ACTIONS_WITHOUT_USERNAMES#10923
Merged
mjac0bs merged 3 commits intolinode:developfrom Sep 12, 2024
Merged
Conversation
added 2 commits
September 11, 2024 13:06
…or a small subset of events
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Sep 11, 2024
coliu-akamai
approved these changes
Sep 11, 2024
Contributor
coliu-akamai
left a comment
There was a problem hiding this comment.
thanks Mariah! saw the bug on develop, confirmed bug is fixed in this branch 🎉
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
One more bug fix...
There are a very small number of events that we consider
ACTIONS_WITHOUT_USERNAMES. Some of these actions have no username, and other we want to override the username withLinode- we have a util calledgetEventUsernameto do this for us.We weren't making use of the username from the util correctly in this component, which we assign at L36.
Without using this util, if a username existed (as it does for
entity_transfer_createevents), we were rendering the wrong initial in the avatar component. Since this is an 'action without username', we want the username to be Linode and to render the Akamai logo as the avatar.We were already using this util in the EventRow component on Event Landing page; the bug was just in the Notification Center event.
No changeset, didn't make it to prod.Adding a changeset because this actually was an existing bug in prod, but becomes more obvious once we start using the initialed avatars.Changes 🔄
usernamefromgetEventUsernameutil to correctly identify events whose usernames we are changing and render the correct avatar accordingly.Target release date 🗓️
9/16/24
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
event.usernamewithLinodewhen passing that prop to the Avatar component. The Akamai logo is displayed as a result.As an Author I have considered 🤔
Check all that apply