upcoming: [M3-8576] – Fix "Create Volume" button state when "Encrypt Volume" checkbox is checked#10929
Merged
dwiley-akamai merged 4 commits intolinode:developfrom Sep 13, 2024
Conversation
…ge when 'Encrypt Volume' checkbox is checked
bnussman-akamai
approved these changes
Sep 12, 2024
|
Coverage Report: ✅ |
coliu-akamai
approved these changes
Sep 13, 2024
Contributor
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ confirmed 'Create Volume' button remains enabled if encrypt option is checked and no linode is selected
✅ confirmed volume create e2e tests pass with new changes
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
The "Create Volume" button should only be disabled when the "Encrypt Volume" checkbox is checked if the user has selected a linode that requires a client library update before an encrypted volume can be attached. Otherwise, the button should be enabled.
Target release date 🗓️
9/30/24
Preview 📷
How to test 🧪
Prerequisites
Point at the dev environment with the
blockstorage-encryptiontag on your accountReproduction steps
On the
developbranch/on the dev site, you will see the "Create Volume" button disabled on the Volume Create page if you check the "Encrypt Volume" checkbox (even if you don't select a linode).Verification steps
If you check the "Encrypt Volume" checkbox and don't select a linode, the "Create Volume" button should remain enabled.
As an Author I have considered 🤔