Skip to content

upcoming: [M3-8576] – Fix "Create Volume" button state when "Encrypt Volume" checkbox is checked#10929

Merged
dwiley-akamai merged 4 commits intolinode:developfrom
dwiley-akamai:M3-8576-create-volume-disabled-fix
Sep 13, 2024
Merged

upcoming: [M3-8576] – Fix "Create Volume" button state when "Encrypt Volume" checkbox is checked#10929
dwiley-akamai merged 4 commits intolinode:developfrom
dwiley-akamai:M3-8576-create-volume-disabled-fix

Conversation

@dwiley-akamai
Copy link
Contributor

Description 📝

The "Create Volume" button should only be disabled when the "Encrypt Volume" checkbox is checked if the user has selected a linode that requires a client library update before an encrypted volume can be attached. Otherwise, the button should be enabled.

Target release date 🗓️

9/30/24

Preview 📷

Before After
Screenshot 2024-09-12 at 10 33 01 AM Screenshot 2024-09-12 at 10 33 11 AM

How to test 🧪

Prerequisites

Point at the dev environment with the blockstorage-encryption tag on your account

Reproduction steps

On the develop branch/on the dev site, you will see the "Create Volume" button disabled on the Volume Create page if you check the "Encrypt Volume" checkbox (even if you don't select a linode).

Verification steps

If you check the "Encrypt Volume" checkbox and don't select a linode, the "Create Volume" button should remain enabled.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added Bug Fixes for regressions or bugs Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption labels Sep 12, 2024
@dwiley-akamai dwiley-akamai self-assigned this Sep 12, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner September 12, 2024 15:56
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai and coliu-akamai and removed request for a team September 12, 2024 15:56
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner September 12, 2024 15:57
@dwiley-akamai dwiley-akamai requested review from cliu-akamai and removed request for a team September 12, 2024 15:57
…ge when 'Encrypt Volume' checkbox is checked
@dwiley-akamai dwiley-akamai changed the title upcoming: [M3-8576] – Fix "Create Voliume" button state when "Encrypt Volume" checkbox is checked upcoming: [M3-8576] – Fix "Create Volume" button state when "Encrypt Volume" checkbox is checked Sep 12, 2024
@github-actions
Copy link

github-actions bot commented Sep 12, 2024

Coverage Report:
Base Coverage: 86.64%
Current Coverage: 86.64%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed 'Create Volume' button remains enabled if encrypt option is checked and no linode is selected
✅ confirmed volume create e2e tests pass with new changes

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Sep 13, 2024
@dwiley-akamai dwiley-akamai merged commit a85f327 into linode:develop Sep 13, 2024
@dwiley-akamai dwiley-akamai deleted the M3-8576-create-volume-disabled-fix branch September 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Block Storage Encryption (BSE) Relating to Block Storage (Volumes) encryption Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants