test: Remove committed Cypress screenshots, simplify .gitignore rules#10932
Merged
jdamore-linode merged 1 commit intolinode:developfrom Sep 13, 2024
Merged
Conversation
|
Coverage Report: ✅ |
carrillo-erik
approved these changes
Sep 12, 2024
bnussman-akamai
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This is a super tiny PR that deletes the screenshots saved in
cypress/screenshotsand simplifies the.gitignorerule around that.These files are super old remnants of (I think?) a visual regression testing implementation we used to have, but soon we'll be uploading test failure screenshots as artifacts in CI, and these files being here makes that difficult (since they'll show up in the artifacts, too).
(We still have plans to implement visual regression testing, and getting rid of these snapshots won't get in the way of that at all)
Changes 🔄
cypress/screenshotsdirectory.gitignorerules for screenshots dir and add a new rule that's consistent with other Cypress output (recordings, results)Target release date 🗓️
N/A
How to test 🧪
No testing needed since nothing depends on these files existing.
As an Author I have considered 🤔
Check all that apply