Skip to content

test: Remove committed Cypress screenshots, simplify .gitignore rules#10932

Merged
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:remove-saved-cypress-screenshots
Sep 13, 2024
Merged

test: Remove committed Cypress screenshots, simplify .gitignore rules#10932
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:remove-saved-cypress-screenshots

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

This is a super tiny PR that deletes the screenshots saved in cypress/screenshots and simplifies the .gitignore rule around that.

These files are super old remnants of (I think?) a visual regression testing implementation we used to have, but soon we'll be uploading test failure screenshots as artifacts in CI, and these files being here makes that difficult (since they'll show up in the artifacts, too).

(We still have plans to implement visual regression testing, and getting rid of these snapshots won't get in the way of that at all)

Changes 🔄

  • Deleted files in cypress/screenshots directory
  • Removed existing .gitignore rules for screenshots dir and add a new rule that's consistent with other Cypress output (recordings, results)

Target release date 🗓️

N/A

How to test 🧪

No testing needed since nothing depends on these files existing.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@github-actions
Copy link

Coverage Report:
Base Coverage: 86.64%
Current Coverage: 86.64%

@jdamore-linode jdamore-linode merged commit 8a540c3 into linode:develop Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants