Filter metrics for internal users#10943
Merged
cpathipa merged 1 commit intolinode:release-v1.128.0from Sep 16, 2024
Merged
Conversation
cpathipa
requested review from
carrillo-erik,
hana-akamai,
hkhalil-akamai and
jaalah-akamai
and removed request for
a team
jaalah-akamai
approved these changes
Sep 16, 2024
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Sep 16, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Verified events are not firing when useIsAkamaiAccount is mocked to true.
Contributor
|
One failing CI test passes locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR avoid's firing LD metrics events for internal users.
Target release date 🗓️
9/16
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply