tech story: Update dompurify and jsPDF to fix dependabot alert#10955
tech story: Update dompurify and jsPDF to fix dependabot alert#10955coliu-akamai merged 4 commits intolinode:developfrom
Conversation
|
Coverage Report: ✅ |
dwiley-akamai
left a comment
There was a problem hiding this comment.
GHA ✅ (the two failing E2E tests seem to be flakes)
No issues with yarn.lock locally ✅
|
update: saw that a jsPDF update just came out to address the dompurify security concern - v2.5.2. I've updated jsPDF on my branch + checked that all tests pass. There shouldn't be any breaking changes based on the release notes, but will be trying to test with generating invoices as well before pushing it up! |
|
@bnussman-akamai @dwiley-akamai just pushed up a change to update jsPDF as well - would you be able to rereview with a focus that there are no regressions in invoice generation 😅 |
bnussman-akamai
left a comment
There was a problem hiding this comment.
Confirmed yarn.lock looks good and PDF invoices are also good ✅
dwiley-akamai
left a comment
There was a problem hiding this comment.
Invoice PDFs look good to me as well 🚢
Description 📝
Fixes dependabot alert here: https://github.com/linode/manager/security/dependabot/121
See #10953 for context
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply