Skip to content

change: [M3-8622] - Update Images empty state as part of Image Service Gen2#10985

Merged
bnussman-akamai merged 6 commits intolinode:developfrom
bnussman-akamai:M3-8622-update-images-empty-state
Sep 24, 2024
Merged

change: [M3-8622] - Update Images empty state as part of Image Service Gen2#10985
bnussman-akamai merged 6 commits intolinode:developfrom
bnussman-akamai:M3-8622-update-images-empty-state

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 23, 2024

Description 📝

  • Updates the Images Landing page empty state based on UX's request as part of Image Service Gen 2 💾

Preview 📷

Before After
Screenshot 2024-09-23 at 11 25 37 AM Screenshot 2024-09-23 at 11 25 02 AM

How to test 🧪

  • Check new copy for correctness 👀
  • Verify all automated testing passes ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Sep 23, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 23, 2024 15:29
@bnussman-akamai bnussman-akamai requested review from abailly-akamai and dwiley-akamai and removed request for a team September 23, 2024 15:29
@github-actions
Copy link

github-actions bot commented Sep 23, 2024

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update images-empty-landing-page.spec.ts as well to reflect the new copy

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending e2e fix

@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 23, 2024 18:38
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and removed request for a team September 23, 2024 18:38
bnussman-akamai and others added 2 commits September 23, 2024 14:44
…ngEmptyStateData.ts

Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants