fix: [M3-8657] - Set full height to DX Tools Modal and add Linode API link#10998
Merged
cpathipa merged 33 commits intolinode:developfrom Sep 24, 2024
Merged
fix: [M3-8657] - Set full height to DX Tools Modal and add Linode API link#10998cpathipa merged 33 commits intolinode:developfrom
cpathipa merged 33 commits intolinode:developfrom
Conversation
This reverts commit b274baf.
cpathipa
requested review from
coliu-akamai and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Sep 24, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Verified the link points to the correct page & DX modal is now full height.
packages/manager/src/features/Linodes/LinodesCreate/ApiAwarenessModal/ApiAwarenessModal.tsx
Outdated
Show resolved
Hide resolved
…ssModal/ApiAwarenessModal.tsx Co-authored-by: Hussain Khalil <122488130+hkhalil-akamai@users.noreply.github.com>
coliu-akamai
approved these changes
Sep 24, 2024
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ confirmed full height
✅ confirmed link
✅ didn't see regressions
thanks Chandra! 🎉
coliu-akamai
added
Approved
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add Linode API link to the DX Tools and Set full height to the DX tools Modal.
Target release date 🗓️
9/30
Preview 📷
Include a screenshot or screen recording of the change
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply