feat: [UIE-8089] - DBaaS Resize GA by smans-akamai · Pull Request #11040 · linode/manager

smans-akamai · 2024-10-02T23:08:13Z

Description 📝

DBaaS Resize GA

Changes 🔄

List any change relevant to the reviewer.

Added Number of Nodes selector to the Database Resize tab
The node selection is cleared if they have 2 nodes option selected and try to switch to a plans tab where it is unavailable.
Updated newly added Node selector so that the plan is cleared if 2 nodes option is selected for a plan that does not have it.
Updated summary so that both current and resize cluster pricing summaries are displayed for comparison

Target release date 🗓️

10/14/24

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

For testing this change, ensure that DBaaS v2 is enabled, Beta is turned off, and the user has the "Managed Databases" account capability

Verification steps

(How to verify changes)

Navigate to the Databases section.
Select the New Databases tab and click into one of the databases to see your details
Navigate to the Resize tab
Scroll down below the plans selection to view the Number of Nodes section is visible
Verify that the correct node options are visible in the different tabs (ie. Dedicated vs Shared, etc)
Verify that your current cluster size is selected and that lower sizes are disabled
Verify that making a higher node selection enables the Resize button
Verify that updated summary is visible and updates with selection
Make an invalid selection for the 2 node option to see the summary remove the current selection

As an Author I have considered 🤔

Check all that apply

github-actions · 2024-10-02T23:59:22Z

Coverage Report: ✅
Base Coverage: 86.96%
Current Coverage: 86.96%

cpathipa · 2024-10-04T00:16:19Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

We can simply this isDatabasesGAEnabled ? 'Please select a plan or set the number of nodes.' : 'Please select a plan.'

This was part of the old version, so I've excluded this change as well.

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

cpathipa · 2024-10-08T14:25:24Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

Can we simplify this to something like this?

{summaryText ? ( <> <StyledPlanSummarySpan> Resized Cluster: {summaryText.plan} </StyledPlanSummarySpan>{' '} {isDatabasesGAEnabled && ( <span className={classes.summarySpanBorder}>{summaryText.basePrice}</span> )} <span className={isDatabasesGAEnabled ? classes.nodeSpanSpacing : ''}> {summaryText.numberOfNodes} Node{summaryText.numberOfNodes > 1 ? 's' : ''} {isDatabasesGAEnabled ? ' - HA ' : ': '} </span> {summaryText.price} </> ) : ( <> <StyledPlanSummarySpan>Resized Cluster:</StyledPlanSummarySpan>{' '} {isDatabasesGAEnabled ? 'Please select a plan or set the number of nodes.' : 'Please select a plan.'} </> )}

@cpathipa Unfortunately, there isn't an easy way to simplify this since many of the smaller changes in the markup are hidden behind that flag so that they won't show without it.

I didn't include this in the my changes, but perhaps we could rework this in a future PR or refactor.

@smans-akamai I would recommend addressing the tech debt in this component, as it has grown too large and will be difficult to maintain in the future. It should be broken down into smaller components, as its current state is not maintainable.

@cpathipa There's an upcoming ticket to refactor the CreateDatabase and ResizeDatabase components since they share a lot similar features (ie. node selector, summary). The ticket is UIE-8082 and that work is set for the 10/28 release and will involve breaking down these similar features into smaller, shared components.

So we should be able to move ahead with this change and address the tech debt and maintainability for these 2 components with that upcoming ticket.

bnussman-akamai · 2024-10-08T15:04:32Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.test.tsx

we should prefer userEvent over fireEvent whenever possible: https://testing-library.com/docs/user-event/intro/#differences-from-fireevent

Suggested change

fireEvent.click(selectedNodeRadioButton);

await userEvent.click(selectedNodeRadioButton);

Thanks @bnussman-akamai! I've included this changes in the test file!

cpathipa

Changes look good to me! Approving pending tests and follow-up tickets for refactoring the DatabaseResize component.

cpathipa · 2024-10-09T10:30:29Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

@smans-akamai I would recommend addressing the tech debt in this component, as it has grown too large and will be difficult to maintain in the future. It should be broken down into smaller components, as its current state is not maintainable.

bnussman-akamai · 2024-10-09T14:57:45Z

packages/manager/src/features/Databases/DatabaseDetail/DatabaseResize/DatabaseResize.tsx

This file needs so serious work

There is way too much state

State like summaryText, nodePricing , and shouldSubmitBeDisabled all seem like states that do not need to exist. They likely should be consts that are derived from existing state. See https://medium.com/@noriller/react-state-x-derived-state-97ff47769914

Fixing these unessesary states will hopefully allow us to remove the useEffects. We are really trying to eliminate use of useEffect in Cloud Manager because they are bug prone and generally a sign of bad state management

@bnussman-akamai
There's an upcoming ticket to refactor the CreateDatabase and ResizeDatabase components since they share a lot similar features (ie. node selector, summary). The ticket is UIE-8082 and that work is set for the 10/28 release and will involve breaking down these similar components into smaller shared components.

This should change how summaryText, and nodePricing are handled since those components share states and logic. I can include a note in the ticket to look into changing how the disabling behavior for the submit button is disabled in Resize, rather than using shouldSubmitBeDisabled in state.

cpathipa · 2024-10-09T15:29:44Z

@smans-akamai Looks like there is E2E test failing in resize-database.spec.ts relevant to this PR. Could you look into this ?

…e cluster_size and export the Engines type

cpathipa

Confirming on the failed e2e test resize-database.spec

cpathipa · 2024-10-09T18:05:09Z

Looks like failed test clone-linode.spec is flaky cc: @jdamore-linode

cpathipa · 2024-10-09T19:18:54Z

After taking with @jdamore-linode internally confirming failed clone-linode.spec is flaky.

cypress · 2024-10-10T15:44:57Z

Cloud Manager E2E Run #6656

Run Properties: Failed #6656 • 6767382768: feat: [UIE-8089] - DBaaS Resize GA (#11040)

Project	`Cloud Manager E2E`
Run status	`Failed #6656`
Run duration	`31m 20s`
Commit	`6767382768: feat: [UIE-8089] - DBaaS Resize GA (#11040)`
Committer	`smans-akamai`
View all properties for this run ↗︎

Test results
Failures	`2`
Flaky	`5`
Pending	`2`
Skipped	`0`
Passing	`428`

Tests for review

cypress/e2e/core/images/machine-image-upload.spec.ts • 2 failed tests

View Output Video

Test		Artifacts
machine image > uploads machine image, mock upload canceled failed event		`Screenshots` `Video`
machine image > uploads machine image, mock failed to decompress failed event		`Screenshots` `Video`

linodes/resize-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
resize linode > resizes a linode by increasing size: cold migration		`Screenshots` `Video`

linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
rebuild linode > cannot rebuild a provisioning linode		`Screenshots` `Video`

placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry		`Screenshots` `Video`

linodes/backup-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
linode backups > can enable backups		`Screenshots` `Video`

kubernetes/smoke-lke-create.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
LKE Create Cluster > Simple Page Check		`Screenshots` `Video`

smans-akamai requested a review from a team as a code owner October 2, 2024 23:08

smans-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team October 2, 2024 23:08

bnussman-akamai assigned smans-akamai Oct 3, 2024

bnussman-akamai added the DBaaS Relates to Database as a Service label Oct 3, 2024

cpathipa requested review from cpathipa and removed request for carrillo-erik October 3, 2024 13:36

smans-akamai force-pushed the UIE-8089-dbaas-resize branch 3 times, most recently from cc97faf to 325cee2 Compare October 7, 2024 22:27

cpathipa requested changes Oct 8, 2024

View reviewed changes

bnussman-akamai reviewed Oct 8, 2024

View reviewed changes

smans-akamai force-pushed the UIE-8089-dbaas-resize branch from 3ae308e to f50d2cf Compare October 8, 2024 19:36

smans-akamai requested review from bnussman-akamai and cpathipa October 8, 2024 20:10

cpathipa approved these changes Oct 9, 2024

View reviewed changes

bnussman-akamai reviewed Oct 9, 2024

View reviewed changes

smans-akamai force-pushed the UIE-8089-dbaas-resize branch from f50d2cf to 6b2aa25 Compare October 9, 2024 16:07

smans-akamai requested a review from a team as a code owner October 9, 2024 16:07

smans-akamai requested review from AzureLatte and removed request for a team October 9, 2024 16:07

smans-akamai added 6 commits October 9, 2024 12:08

feat: [UIE-8089] - DBaaS Resize

4c4b613

Added changeset: Number of Nodes selector for DBaaS GA Resize

ad3481d

Added changeset: Databases types to have UpdateDatabasePayload includ…

f058c77

…e cluster_size and export the Engines type

Applying requested selection behavior

21f23ec

Applying design changes to summary and updating unit tests

d4fc3d8

Applying feedback and updating unit and e2e tests

ebdf47c

smans-akamai force-pushed the UIE-8089-dbaas-resize branch from 6b2aa25 to ebdf47c Compare October 9, 2024 16:09

smans-akamai requested review from bnussman-akamai and cpathipa October 9, 2024 16:10

cpathipa approved these changes Oct 9, 2024

View reviewed changes

cpathipa removed request for AzureLatte and coliu-akamai October 9, 2024 19:03

bnussman-akamai approved these changes Oct 10, 2024

View reviewed changes

mjac0bs merged commit 6767382 into linode:develop Oct 10, 2024

This was referenced Oct 10, 2024

Release v1.130.0 - release → staging #11087

Merged

Release v1.130.0- staging → master #11095

Merged

smans-akamai deleted the UIE-8089-dbaas-resize branch September 9, 2025 20:23

	fireEvent.click(selectedNodeRadioButton);
	await userEvent.click(selectedNodeRadioButton);

Conversation

smans-akamai commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Uh oh!

github-actions bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpathipa commented Oct 9, 2024

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

cpathipa commented Oct 9, 2024

Uh oh!

cpathipa commented Oct 9, 2024

Uh oh!

cypress bot commented Oct 10, 2024

Tests for review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smans-akamai commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024 •

edited

Loading