fix: [M3-8774 ] - Faux bold in Safari with <strong /> & <b /> tags
#11149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
bnussman-akamai and
hkhalil-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Oct 23, 2024
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks good! I can finally have some peace as a Safari user now 😅
Wonder if the CSS fix is best here or if it could/should be addressed in MUI
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Oct 23, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Neat! This also fixes the same issue in Firefox.
Wonder if the CSS fix is best here or if it could/should be addressed in MUI
I believe it's in the right spot since they are not MUI components.
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 24m 50s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
441
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
It does appear global CSS isn't picked up in Safari for
<strong>and<b>tags, resulting in faux bold. This seems to happen systematically during DOM injectionThe issue seems to stem from the browser having higher specificity over our global CSS declaration. This PR nests our
strong&bCSS declaration to increase specificity, which seems to fix the problem overallChanges 🔄
strong&bfor SafariPreview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply