fix: [M3-8788] - Only run coverage comment job on non-drafts #11161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
hana-akamai and
mjac0bs
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 25, 2024
mjac0bs
reviewed
Oct 25, 2024
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
mjac0bs
approved these changes
Oct 25, 2024
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks Alban! Looking forward to the decrease in noise with this change.
mjac0bs
changed the title
Contributor
Author
|
it works! |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 07s |
| Commit |
|
| Committer | Alban Bailly |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
https://github.com/linode/manager/actions/workflows/coverage_comment.yml?query=is:failure
The "Coverage Comment" GHA depends on the "Code Coverage" workflow to be completed. However that job is designed to not run on draft, so every time a draft gets updates this job fails, because apparently it assumes the job is completed when it never runs.
This flag should fix this and remove some noise when running on drafts.
There unfortunately isn't a way to check this works until this is merged but I have confidence this should do it, and if not we can always do a quick revert
Changes 🔄
As an Author I have considered 🤔
Check all that apply