test: [M3-8769] - Add Docker Compose service to reverse proxy Cloud in CI #11177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 28, 2024 15:26
jdamore-linode
requested review from
coliu-akamai and
cpathipa
and removed request for
a team
jdamore-linode
commented
Oct 28, 2024
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 29, 2024
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Nice. Caddy is awesome! I use it to reverse proxy things I self hosted at 🏠
jaalah-akamai
approved these changes
Nov 1, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 19s |
| Commit |
|
| Committer | jdamore-linode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
444
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/kubernetes/lke-create.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| LKE Cluster Creation > can create an LKE cluster |
Screenshots
Video
|
|
stackscripts/create-stackscripts.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Create stackscripts > creates a StackScript with Any/All target image |
Screenshots
Video
|
|
objectStorageGen2/bucket-object-gen2.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Object Storage Gen2 bucket object tests > can check Object details drawer with E0 endpoint type |
Screenshots
Video
|
|
placementGroups/delete-placement-groups.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR includes Docker changes that are necessary to reverse proxy containerized Cloud Manager instances in CI. This allows our CI tools to automate containerized Cloud instances and perform actions that are only available in secure browser contexts.
Notably, this is necessary to unblock our OAuth PKCE work (#10600) which includes changes that cannot be tested in environments where a secure context is not available.
Once this PR is merged, additional (minor) CI changes will need to be made to use the new Docker Compose service. I don't believe any changes are necessary for GitHub Actions since Cloud is served from
localhost:3000already.Changes 🔄
expectandopenssh-clientinstallation -- these packages are no longer needed since we removed our Longview end-to-end teste2e-reverse-proxyDocker build target which is identical toe2ebut includes caddycypress-containerizedDocker Compose service to test against a local containerized Cloud instance-- The key difference between
cypress-localandcypress-containerizedis thatcypress-containerizedhas a reverse proxy running that allows Cloud to be accessed from inside the container atlocalhost:3000, which is what allows us to achieve a secure context from the testsnodejs-cloud-managerbuild target that includes bun and pnpm (cc @bnussman-akamai)Target release date 🗓️
N/A, but we will probably want these changes to sit in
developfor a few days before changing our CI pipelines since the pipeline changes will causebreakage against any branches/PRs that pre-date this change.How to test 🧪
This can't be easily tested since the CI changes haven't been made (this PR accomplishes basically nothing on its own). However, I did do a test run that demonstrates that these changes work and that they allow the OAuth/PKCE changes to be tested. I've included a link to that run in the Jira ticket, as well as some details as to how that run was achieved, etc.
As an Author I have considered 🤔
Check all that apply