refactor: [M3-8827] - Migrate CircleProgress to ui package
#11214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
requested review from
coliu-akamai and
mjac0bs
and removed request for
a team
mjac0bs
approved these changes
Nov 13, 2024
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Diff looked good to me, didn't see regressions when spot-checking the loading component throughout Cloud, story loads, unit test passes. Cypress failure is unrelated and has to do with the region select's displayed value on the clone linode flow.
The one thing I noticed, which would be a 'nice-to-have' since it's a bit out of scope of this PR, is that the story for CircleProgress doesn't show any args, and size is one it may be helpful to see.
coliu-akamai
approved these changes
Nov 14, 2024
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
looks good, thank you 🚀
We could consolidate some imports here, but I know we're also discussing doing it at the end so either sounds good!
coliu-akamai
added
Approved
|
Coverage Report: ❌ |
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 41m 46s |
| Commit |
|
| Committer | Jaalah Ramos |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
444
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/volumes/delete-volume.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| volume delete flow > deletes a volume |
Screenshots
Video
|
|
linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
stackscripts/create-stackscripts.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Create stackscripts > creates a StackScript with Any/All target image |
Screenshots
Video
|
|
linodes/clone-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
objectStorageGen2/bucket-object-gen2.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Object Storage Gen2 bucket object tests > can check Object details drawer with E0 endpoint type |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
CircleProgressto theuipackage.Target release date 🗓️
12/10/24
How to test 🧪
Verification steps
CircleProgressAs an Author I have considered 🤔