refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 #11241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmakode-akamai
changed the title
pmakode-akamai
requested review from
coliu-akamai and
dwiley-akamai
and removed request for
a team
|
Coverage Report: ❌ |
dwiley-akamai
changed the title
dwiley-akamai
approved these changes
Nov 13, 2024
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
No styling regressions observed in Cloud ✅
Code review ✅
pmakode-akamai
changed the title
Collaborator
Cloud Manager UI test results🎉 445 passing tests on test run #12 ↗︎
|
coliu-akamai
approved these changes
Nov 15, 2024
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ cloud manager styling
✅ code review
thank you!
coliu-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 23s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
452
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Note
The new colors are based on design tokens and have been selected to closely match the existing colors.
Related PRs:
Changes 🔄
pinkwiththeme.tokens.color.Pink[40](#f3c6e2)#e3e5e8withtheme.tokens.color.Neutrals[20]and its equivalent color (#E5E5EA) inmonitor-disabled.svg#2e3238withtheme.tokens.color.Neutrals[100](#343438)#c9c7c7withtheme.tokens.color.Neutrals[40](#c2c2ca)#606469withtheme.tokens.color.Neutrals[70](#696970)#555withtheme.tokens.color.Neutrals[80](#515157)#c9cacbwiththeme.tokens.color.Neutrals[40]orColor.Neutrals[40]and its equivalent color (#c2c2ca) intoggleOff.svg#9ea4aewiththeme.tokens.color.Neutrals[50](#a3a3ab)#cdd0d5withtheme.tokens.color.Neutrals[30](#d6d6dd)#cccwiththeme.tokens.color.Neutrals[40](#c2c2ca)#222withtheme.tokens.color.Neutrals.Black(#232326)#f4f4f4withtheme.tokens.color.Neutrals[5]or equivalent (#f7f7fa)Target release date 🗓️
N/A
Preview 📷
How to test 🧪
As an Author I have considered 🤔
Check all that apply