refactor: [M3-8908] - Optimize Events Polling following changes from incident#11263
Merged
bnussman-akamai merged 13 commits intolinode:developfrom Nov 19, 2024
Merged
Conversation
abailly-akamai
approved these changes
Nov 19, 2024
Contributor
abailly-akamai
left a comment
There was a problem hiding this comment.
Solid PR - did not notice any regression with any of the eventing scenarios I tried:
- event polling ✅
- events page (with and without events) ✅
- events page infinite scrolling ✅
- linode activity ✅
@bnussman-akamai only thing is you'll need is a changeset
|
Coverage Report: ✅ |
Collaborator
Cloud Manager UI test results🎉 453 passing tests on test run #6 ↗︎
|
mjac0bs
approved these changes
Nov 19, 2024
Contributor
mjac0bs
left a comment
There was a problem hiding this comment.
Verified:
- Events landing page in general
- Mocking 0 events displays no results and the 'You don't have any events on your account' copy
- Mocking 0 events in the last 7 days but older events past 7 days displays those older events
- Events infinitely scroll
- The activity feed on a Linode details page shows recent and past 7 days events for that Linode
- Polling works - the progress bar for in-progress events updates every few seconds that polling happens
- Events are marked as seen when the notification center is viewed
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 39s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
1
|
|
|
0
|
|
|
2
|
|
|
0
|
|
|
452
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/stackscripts/update-stackscripts.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Update stackscripts > updates a StackScript |
Screenshots
Video
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
useInitialEventsQueryhook and moves all logic intouseEventsInfiniteQuery, similar to the implementation before change: [M3-8450] - Lower Events historical data fetching to 7 days #10899useEventsInfiniteQuerythat ensures the first fetch always limited to a 7 day window 📆Preview 📷
Note
No UI changes expected
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅