refactor: [M3-8645] - Move Chip to ui package#11266
Merged
pmakode-akamai merged 11 commits intolinode:developfrom Nov 18, 2024
Merged
refactor: [M3-8645] - Move Chip to ui package#11266pmakode-akamai merged 11 commits intolinode:developfrom
Chip to ui package#11266pmakode-akamai merged 11 commits intolinode:developfrom
Conversation
hasyed-akamai
changed the title
hasyed-akamai
changed the title
Chip to ui package
hasyed-akamai
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
should use import type whenever we import types and keep these types at the bottom of imports as per eslint rule
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Nov 15, 2024
hkhalil-akamai
approved these changes
Nov 15, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Looks good. Maybe we should move the changeset category?
Contributor
There was a problem hiding this comment.
Removed might be a better fit?
Contributor
There was a problem hiding this comment.
Agreed. Moving forward, I think we're settling on a Removed changeset for manager and an Added changeset for ui for these component migration PRs.
dwiley-akamai
approved these changes
Nov 15, 2024
Contributor
There was a problem hiding this comment.
Agreed. Moving forward, I think we're settling on a Removed changeset for manager and an Added changeset for ui for these component migration PRs.
pmakode-akamai
force-pushed
the
move-chip-from-manager-to-ui-package
branch
from
9c6a6ad to
f46fa3f
Compare
hasyed-akamai
added
Approved
Collaborator
Cloud Manager UI test results🎉 452 passing tests on test run #10 ↗︎
|
pmakode-akamai
approved these changes
Nov 18, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 10s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
452
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Migrate
Chipto uipackageTarget release date 🗓️
N/A
How to test 🧪
Check all that apply