Skip to content

Conversation

@dwiley-akamai
Copy link
Contributor

Description 📝

Migrate TooltipIcon from manager to ui package.

Target release date 🗓️

12/10/24

How to test 🧪

Verification steps

  • All tests should pass
  • There should be no regressions observed in Cloud
  • TooltipIcon story in Storybook should be in good shape

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dwiley-akamai dwiley-akamai self-assigned this Nov 15, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner November 15, 2024 17:49
@dwiley-akamai dwiley-akamai requested review from hana-akamai and mjac0bs and removed request for a team November 15, 2024 17:49
@github-actions
Copy link

Coverage Report:
Base Coverage: 87.32%
Current Coverage: 87.3%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dwiley-akamai! there's a few merge conflicts but otherwise looks good 🎉

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good! Tooltip renders as expected. 👍🏼

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Nov 18, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing451 Passing2 Skipped106m 15s

Details

Failing Tests
SpecTest
migrate-linode.spec.tsMigrate linodes » shows DC-specific pricing information when migrating linodes to similarly priced DCs

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"

@dwiley-akamai dwiley-akamai merged commit be0566c into linode:develop Nov 18, 2024
19 of 20 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8708-tooltipicon-ui-package branch November 18, 2024 21:27
@cypress
Copy link

cypress bot commented Nov 18, 2024

Cloud Manager E2E    Run #6844

Run Properties:  status check passed Passed #6844  •  git commit be0566c9ee: refactor: [M3-8708] – Migrate `TooltipIcon` to `ui` package (#11269)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6844
Run duration 27m 35s
Commit git commit be0566c9ee: refactor: [M3-8708] – Migrate `TooltipIcon` to `ui` package (#11269)
Committer Dajahi Wiley
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 453
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Modularization

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants