-
Notifications
You must be signed in to change notification settings - Fork 391
refactor: [M3-8708] – Migrate TooltipIcon to ui package
#11269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8708] – Migrate TooltipIcon to ui package
#11269
Conversation
|
Coverage Report: ❌ |
coliu-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @dwiley-akamai! there's a few merge conflicts but otherwise looks good 🎉
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good! Tooltip renders as expected. 👍🏼
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 35s |
| Commit |
|
| Committer | Dajahi Wiley |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
2
|
|
|
2
|
|
|
0
|
|
|
453
|
| View all changes introduced in this branch ↗︎ | |
Description 📝
Migrate
TooltipIconfrommanagertouipackage.Target release date 🗓️
12/10/24
How to test 🧪
Verification steps
TooltipIconstory in Storybook should be in good shapeAs an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅