fix: [M3-8740] - Convert Object Storage size from GiB to GB in frontend
#11293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpathipa
reviewed
Nov 22, 2024
Contributor
cpathipa
left a comment
cpathipa
left a comment
There was a problem hiding this comment.
@hasyed-akamai You might need to adjust the broken unit tests w.r.t your changes.
| variant="body1" | ||
| > | ||
| {readableBytes(props.sizeInBytes).formatted} | ||
| {readableBytes(props.sizeInBytes, { base10: true }).formatted} |
Contributor
There was a problem hiding this comment.
Nit: You could add a comment to provide context for enabling base10.
Contributor
There was a problem hiding this comment.
Optional: this comment is not super clear. Essentially what you are doing here is converting from binary units (GiB) to decimal units (GB).
hasyed-akamai
requested review from
abailly-akamai and
carrillo-erik
and removed request for
a team
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Dec 2, 2024
| variant="body1" | ||
| > | ||
| {readableBytes(props.sizeInBytes).formatted} | ||
| {readableBytes(props.sizeInBytes, { base10: true }).formatted} |
Contributor
There was a problem hiding this comment.
Optional: this comment is not super clear. Essentially what you are doing here is converting from binary units (GiB) to decimal units (GB).
Collaborator
Cloud Manager UI test results🎉 466 passing tests on test run #8 ↗︎
|
harsh-akamai
approved these changes
Dec 5, 2024
Contributor
harsh-akamai
left a comment
harsh-akamai
left a comment
There was a problem hiding this comment.
Changes look good! Thanks @hasyed-akamai
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 29m 54s |
| Commit |
|
| Committer | hasyed-akamai |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Dec 5, 2024
hasyed-akamai
added
Approved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR changes the Object Storage bucket size numbers from
GiBtoGBin the frontend to avoid confusion during migration.Previously, the size numbers were displayed in
GiB, and now they are displayed inGB.Changes 🔄
GiBtoGBin the frontend.Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
GBin the frontend.Verification steps
GBin the frontend.As an Author I have considered 🤔
Check all that apply