-
Notifications
You must be signed in to change notification settings - Fork 392
upcoming: [M3-9141] - Add udp_check_port support to NodeBalancers
#11534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-9141] - Add udp_check_port support to NodeBalancers
#11534
Conversation
udp_check_port to NodeBalancersudp_check_port support to NodeBalancers
|
Coverage Report: ✅ |
hana-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/cypress/e2e/core/nodebalancers/smoke-create-nodebal.spec.ts
Outdated
Show resolved
Hide resolved
|
@hana-akamai I honestly don't know how to do that with MUI grid. Does this look any better? |
|
@bnussman hmm looks a bit too cramped with 3 side by side, I guess we can keep it as is I'm getting an error when trying to save the UDP changes, is this expected? |
|
@hana-akamai I wasn't able to replicate that. You'll need the |
Cloud Manager UI test results🔺 1 failing test on test run #17 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 30m 22s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
4
|
|
|
2
|
|
|
0
|
|
|
482
|
| View all changes introduced in this branch ↗︎ | |



Description 📝
udp_check_portNodeBalancer config field ➕tcpprotocol is selected 🚫Preview 📷
How to test 🧪
udpflag is enablednb-udp-alphacustomer tagUDPfor this new field to be visibleAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅