hotfix: Uptime interface for LongView API response #11667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
changed the title
harsh-akamai
requested review from
hasyed-akamai and
mjac0bs
and removed request for
a team
harsh-akamai
changed the title
bnussman-akamai
previously approved these changes
Feb 18, 2025
mjac0bs
previously approved these changes
Feb 18, 2025
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Confirmed that Uptime is now rendering, thanks for the fix, @harsh-akamai. It would be good to follow this PR up with some test coverage in longview.spec.ts.
| Prod | This Branch |
|---|---|
 |
 |
Contributor
|
@hkhalil-akamai Oh, this needs a changelog update. It has the version bump. |
hkhalil-akamai
dismissed stale reviews from mjac0bs and bnussman-akamai
via
faf4972
mjac0bs
approved these changes
Feb 18, 2025
hkhalil-akamai
approved these changes
Feb 18, 2025
|
Coverage Report: ✅ |
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/kubernetes/smoke-lke-create.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Bug Summary 🐛
Uptimewhich has been incorrectly mapped in CM asuptime. This in turn displays 'Uptime not available'.https://github.com/linode/manager/blob/develop/packages/manager/src/features/Longview/request.types.ts#L120-L121
The Fix 🔧
Uptimeto rightly have a keyUptimeinstead ofuptimePreview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅