Skip to content

Conversation

@agorthi-akamai
Copy link
Contributor

Description ๐Ÿ“

Highlight the Pull Request's context and intentions.

Changes ๐Ÿ”„

List any change(s) relevant to the reviewer.

  • ...
  • ...

Target release date ๐Ÿ—“๏ธ20/02/2025

๐Ÿ‘€ Doing a self review
โ” Our contribution guidelines
๐Ÿค Splitting feature into small PRs
โž• Adding a changeset
๐Ÿงช Providing/improving test coverage
๐Ÿ” Removing all sensitive information from the code and PR description
๐Ÿšฉ Using a feature flag to protect the release
๐Ÿ‘ฃ Providing comprehensive reproduction steps
๐Ÿ“‘ Providing or updating our documentation
๐Ÿ•› Scheduling a pair reviewing session
๐Ÿ“ฑ Providing mobile support
โ™ฟ Providing accessibility support



@agorthi-akamai agorthi-akamai requested a review from a team as a code owner February 20, 2025 16:44
@agorthi-akamai agorthi-akamai requested review from dmcintyr-akamai and removed request for a team February 20, 2025 16:44
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround @agorthi-akamai!

@coliu-akamai coliu-akamai changed the title test [DI-23274]: fixing the lint issue test: [DI-23274] - Fix lint issue for create-user-alert.spec.ts Feb 20, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

๐ŸŽ‰ 523 passing tests on test run #1 โ†—๏ธŽ

โŒ Failingโœ… Passingโ†ช๏ธ Skipped๐Ÿ• Duration
0 Failing523 Passing3 Skipped114m 36s

@github-actions
Copy link

Coverage Report: โœ…
Base Coverage: 79.98%
Current Coverage: 79.98%

@jdamore-linode jdamore-linode merged commit 414c0a7 into linode:develop Feb 20, 2025
23 checks passed
@cypress
Copy link

cypress bot commented Feb 20, 2025

Cloud Manager E2Eย  ย  Run #7258

Run Properties:ย  status check passedย Passedย #7258 ย โ€ขย  git commit 414c0a749c: DI-23274: fixing the lint issue (#11697)
Project Cloud Manager E2E
Branch Review develop
Run status status check passedย Passedย #7258
Run duration 32m 27s
Commit git commit 414c0a749c: DI-23274: fixing the lint issue (#11697)
Committer agorthi-akamai
View all properties for this run โ†—๏ธŽ

Test results
Tests that failedย  Failures 0
Tests that were flakyย  Flaky 5
Tests that did not run due to a developer annotating a test with .skipย  Pending 3
Tests that did not run due to a failure in a mocha hookย  Skipped 0
Tests that passedย  Passing 523
View all changes introduced in this branch โ†—๏ธŽ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants