fix: Update LKE Tiered Version endpoints#11703
Conversation
coliu-akamai
requested review from
bill-akamai,
hasyed-akamai and
mjac0bs
and removed request for
a team
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
I think we want to update the Cypress intercept util for this endpoint too: https://github.com/linode/manager/blob/develop/packages/manager/cypress/support/intercepts/lke.ts#L80
Approved pending that + automated test results
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Confirmed we look good with the staging API locally:
Screen.Recording.2025-02-21.at.8.19.46.AM.mov
Thanks Connie - approving pending Joe's test comment.
coliu-akamai
dismissed stale reviews from mjac0bs and jdamore-linode
via
8d0e2c1
coliu-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
|
thanks Joe and Mariah, just pushed up the change - will need a rereview |
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks for responding to and tackling this so quickly @coliu-akamai! Approved pending test results
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
🚀 Not expecting any issues with tests. Ty, ty!
Local run
|
Coverage Report: ✅ |
|
🚀 |
Cloud Manager UI test results🎉 521 passing tests on test run #3 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
staging
|
| Run status |
|
| Run duration | 32m 16s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
521
|
| View all changes introduced in this branch ↗︎ | |
* Update LKE Tiered Version endpoints * update cypress test util
5 participants
Description 📝
Updates LKE tiered version endpoints to match new API changes (see internal slack thread / apinext pr 7547 for details)
Target release date 🗓️
2/25
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅