Skip to content

Conversation

@mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Mar 7, 2025

Description 📝

Ignore me - doing some testing with Richa/Adobe Launch and creating this for the preview link.

Note

This work became combined with the effort to switch Cloud Manager to using its own Adobe Launch script, so we will roll out the change after 5/20, when we will be using the new Adobe Launch script with Pendo in production.

TODO:

  • Close this PR after the next release when the new dev script is in use everywhere and open a new one with cleaner history:
    • e1f962c
    • f3d47e6
    • d2ea10a
    • TODO: Clean up the Optanon cookie check logic.
    • TODO: Update the develop docs with anything inaccurate.
    • TODO: Add test coverage to analytics.spec.ts to confirm the Pendo agent has loaded as part of Adobe Launch

Changes 🔄

List any change(s) relevant to the reviewer.

  • ...
  • ...

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
📷 📷

How to test 🧪

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs self-assigned this Mar 7, 2025
@mjac0bs mjac0bs force-pushed the POC-rely-on-adobe-launch-for-pendo-agent branch 2 times, most recently from 4a02118 to 36e2be0 Compare March 26, 2025 20:18
@mjac0bs mjac0bs force-pushed the POC-rely-on-adobe-launch-for-pendo-agent branch from 36e2be0 to 2380a94 Compare April 10, 2025 14:21
@mjac0bs mjac0bs force-pushed the POC-rely-on-adobe-launch-for-pendo-agent branch from a64dfda to 58db65d Compare April 21, 2025 21:03
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #14 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing574 Passing5 Skipped145m 2s

Details

Failing Tests
SpecTest
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuild linode
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuild linode
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuild linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts"

@mjac0bs
Copy link
Contributor Author

mjac0bs commented May 16, 2025

We don't need this PR any more - see M3-9347 up for review.

@mjac0bs mjac0bs closed this May 16, 2025
@github-project-automation github-project-automation bot moved this from Review to Merged in Cloud Manager May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants