upcoming: [M3-9512] - Update types and validation for VPC subnet #11896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
requested review from
cliu-akamai,
dwiley-akamai and
mjac0bs
and removed request for
a team
hana-akamai
commented
Mar 21, 2025
| }); | ||
|
|
||
| // @TODO VPC: Delete this when IPv6 is in GA | ||
| export const createSubnetSchemaIPv4 = object({ |
Contributor
Author
There was a problem hiding this comment.
I separated createSubnetSchema into createSubnetSchemaIPv4 and createSubnetSchemaWithIPv6 for now as to not effect how subnets currently work with ipv4.
- If a customer does not have access to ipv6, we don't want to show the
IP_EITHER_BOTH_NOT_NEITHERmessage - If a customer has access to ipv6, we want to show the
IP_EITHER_BOTH_NOT_NEITHERmessage instead ofTEMPORARY_IPV4_REQUIRED_MESSAGE
We'll need feature flag logic to determine which Schema to use which we can do when implementing ipv6 logic to the subnet flow
dwiley-akamai
approved these changes
Mar 21, 2025
packages/api-v4/.changeset/pr-11896-upcoming-features-1742491246746.md
Outdated
Show resolved
Hide resolved
packages/validation/.changeset/pr-11896-upcoming-features-1742491352504.md
Outdated
Show resolved
Hide resolved
mjac0bs
approved these changes
Mar 21, 2025
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Updates to api-v4 look consistent with the API spec and the changes to separate out the schemas makes sense.
Thanks Hana 🚢
mjac0bs
added
Approved
hana-akamai
added
Add'tl Approval Needed
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
This was referenced Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Update types and validation for VPC Subnet
Changes 🔄
ipv6type forCreateSubnetPayloadcreateSubnetSchemaintocreateSubnetSchemaIPv4andcreateSubnetSchemaWithIPv6vpcsValidateIPipv6 subnetschema validation invpcs.schema.tsHow to test 🧪
Verification steps
Cross-reference VPC IPv6 API spec (linked in parent ticket) and updated types for:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅