fix: Linode Rebuild dialog erroring when Reuse user data previously provide is checked
#11902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v1.138.0 - release → staging
bnussman-akamai
requested review from
abailly-akamai,
cpathipa and
jdamore-linode
and removed request for
a team
bnussman-akamai
commented
Mar 20, 2025
Member
Author
There was a problem hiding this comment.
Just wanted to add more context and make the code more readable. This code accomplishes the same thing as it did before.
Member
Author
There was a problem hiding this comment.
This is the fix.
Collaborator
Cloud Manager UI test results🎉 540 passing tests on test run #1 ↗︎
|
abailly-akamai
approved these changes
Mar 21, 2025
| }); | ||
|
|
||
| ui.toast.assertMessage('Linode rebuild started.'); | ||
| }); |
coliu-akamai
approved these changes
Mar 24, 2025
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ testing rebuild with various configurations of user data + checkbox
✅ confirm test passes - ty for added coverage!
thank you!
bnussman-akamai
merged commit 01207ca
into
linode:release-v1.138.0
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The Bug 🐛
Reuse user data previously providedcheckbox checked, a client-side validation error would occurMetadataSchemawould break this flow.How to test 🧪
Reuse user data previously providedcheckbox checkedAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅