Skip to content

Conversation

@coliu-akamai
Copy link
Contributor

Description 📝

  • some padding/margins seem off for Linode entity details vs prod, potentially another regression from MUIv6. I tried fixing them to make it look like prod again ... hopefully!

No changeset needed - this hasn't hit prod yet

Target release date 🗓️

3/25

Preview 📷

large small screen
prod image image
before image image
after image image

How to test 🧪

Reproduction steps

  • check out develop
  • notice styling for Linode entity detail

Verification steps

  • Confirm styling is fixed
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai added the Bug Fixes for regressions or bugs label Mar 24, 2025
@coliu-akamai coliu-akamai self-assigned this Mar 24, 2025
@coliu-akamai coliu-akamai marked this pull request as ready for review March 24, 2025 13:39
@coliu-akamai coliu-akamai requested a review from a team as a code owner March 24, 2025 13:39
@coliu-akamai coliu-akamai requested review from abailly-akamai and bill-akamai and removed request for a team March 24, 2025 13:39
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 24, 2025
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better! Thanks 🙏

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 6 failing tests on test run #1 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
6 Failing532 Passing4 Skipped151m 1s

Details

Failing Tests
SpecTest
delete-firewall.spec.tsdelete firewall » deletes a firewall
object-storage.e2e.spec.tsobject storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"
update-firewall.spec.tsupdate firewall » updates a firewall's status
clone-linode.spec.tsclone linode » can clone a Linode from Linode details page
lke-create.spec.tsLKE Cluster Creation » can create an LKE cluster
lke-create.spec.tsLKE Cluster Creation with APL enabled » can create an LKE cluster with APL flag enabled

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/delete-firewall.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

@coliu-akamai
Copy link
Contributor Author

...that is quite a few test failures... reviewing them, they look unrelated to these changes - merging!

@coliu-akamai coliu-akamai merged commit ffaad2e into linode:release-v1.138.0 Mar 24, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 24, 2025
@coliu-akamai coliu-akamai deleted the fix-entity-details-styling branch March 24, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants