Skip to content

Conversation

@dwiley-akamai
Copy link
Contributor

@dwiley-akamai dwiley-akamai commented May 30, 2025

Description 📝

Update the outer and inner subnet tables to include new IPv6 columns and conditionally change the names of some existing columns depending on the feature flag.

Changes 🔄

  • "Subnet IP Range" outer table column --> "Subnet IPv4 Range" when feature flag is on
  • New "Subnet IPv6 Range" outer table column when feature flag is on
  • "VPC IPv4 Ranges" inner table (Linodes) column --> "Linode IPv4 Ranges" when feature flag is on
  • New "VPC IPv6" and "Linode IPv6 Ranges" inner table (Linodes) columns when feature flag is on

Target release date 🗓️

8/12/25

Preview 📷

Before After
Screenshot 2025-07-18 at 4 55 12 PM Screenshot 2025-07-28 at 10 44 09 AM

How to test 🧪

Prerequisites

  • functioning DevEnv
  • vpc-ipv6 tag on your account

(Reach out for more instructions if needed)

Verification steps

  • Create a dual stack VPC
  • Create a subnet with IPv6
    • Observe: the "Subnet IPv6 Range" value for the subnet should have a prefix length (i.e., the /XX part) that matches what you selected in the Create Subnet drawer
  • Create a linode via the command line that is assigned to the dual stack VPC & the subnet you just created (reach out for a boiler plate terminal command if needed)
    • Observe: the inner Linode table for that subnet should show the newly-assigned linode, with the "VPC IPv6" and "Linode IPv6 Ranges" cells populated as expected
    • IPv6 columns displayed as long as the feature flag is on -- for VPCs/subnets that don't support IPv6, you should see an em dash (—) in the cell for that column value
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@github-actions
Copy link

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Jul 13, 2025
@github-actions github-actions bot removed the Stale label Jul 17, 2025
@dwiley-akamai dwiley-akamai marked this pull request as ready for review July 21, 2025 22:31
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner July 21, 2025 22:31
@dwiley-akamai dwiley-akamai requested review from coliu-akamai, hana-akamai and hasyed-akamai and removed request for a team July 21, 2025 22:31
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changeset for the utilities package as well?

})}
</TableCell>
</Hidden>
{flags.vpcIpv6 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if the VPC is dualstack as well so we don't show IPv6 for non-dualstack VPCs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking with Daniel if we want to display the IPv6 columns for all VPCs or not (and also if we should use dashes instead of "None")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: using dashes vs hiding the ipv6 columns, I assigned several Linodes to a non-dualstack VPC. If the VPC has a lot of Linodes assigned to it, there will be a lot of rows with only dashes. Maybe displaying a chip or something like LKE clusters' HA cluster symbol in the VPC's description and hiding the columns could be another option?

image image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a more detailed comment on the ticket, but the decision (at this time) was to display the columns for all VPCs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DevDW what was UX's reasoning for displaying the IPv6 columns for all VPCs? It seems like unnecessary clutter imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hana-akamai Essentially a consistent view across all VPCs + an effort to convey that IPv6 can't be used for non-Dual Stack VPCs (at this time, there's no way to add or remove IPv6 prefixes from a VPC and it isn't planned). I will resurface this feedback to Daniel tomorrow once he's back in though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hana-akamai @coliu-akamai Daniel is going to bring the topic up with the wider team this week -- if we end up changing how the columns are handled, I'll create a separate ticket to take care of that 👍🏾 Would be great to get this merged while that is being explored in the background

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ Observe: the inner Linode table for that subnet should show the newly-assigned linode, with the "VPC IPv6" and "Linode IPv6 Ranges" cells populated as expected
  • ✅ IPv6 columns displayed as long as the feature flag is on -- for VPCs/subnets that don't support IPv6, you should see an em dash (—) in the cell for that column value
  • ✅ no IPv6 columns displayed if feature flag is disabled

thanks @dwiley-akamai!

})}
</TableCell>
</Hidden>
{flags.vpcIpv6 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: using dashes vs hiding the ipv6 columns, I assigned several Linodes to a non-dualstack VPC. If the VPC has a lot of Linodes assigned to it, there will be a lot of rows with only dashes. Maybe displaying a chip or something like LKE clusters' HA cluster symbol in the VPC's description and hiding the columns could be another option?

image image

@dabaka
Copy link

dabaka commented Jul 29, 2025

Hello @DevDW - can we not change the labels on the ranges to Linode IPv4 Ranges and Linode IPv6 Ranges? Let's keep them as they are for now VPC IPvX Ranges.

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending the VPCSubnetsTable unit test failure is addressed

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 29, 2025
@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Jul 29, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #22 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing691 Passing4 Skipped139m 16s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@dwiley-akamai dwiley-akamai merged commit 115ee9d into linode:develop Jul 29, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 29, 2025
@dwiley-akamai dwiley-akamai deleted the M3-9864-inner-subnet-tables-new-columns branch July 29, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! VPC IPv6

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants