Skip to content

tests: [M3-10071] - aclpBetaServices smokeTests#12310

Merged
dmcintyr-akamai merged 35 commits intolinode:developfrom
dmcintyr-akamai:M3-10071_ff_smokeTests
Jul 3, 2025
Merged

tests: [M3-10071] - aclpBetaServices smokeTests#12310
dmcintyr-akamai merged 35 commits intolinode:developfrom
dmcintyr-akamai:M3-10071_ff_smokeTests

Conversation

@dmcintyr-akamai
Copy link
Contributor

@dmcintyr-akamai dmcintyr-akamai commented Jun 2, 2025

Description 📝

Verify that the upgrade/downgrade banner is not visible when the aclpBetaServices.alerts or aclpBetaServices.metrics feature flag is disabled, regardless of what the user preference is.

Changes 🔄

4 new tests:

  1. isAclpAlertsBeta = false
  2. isAclpAlertsBeta = true
  3. isAclpMetricsBeta = false
  4. isAclpMetricsBeta = true

In each of these tests no upgrade or downgrade banner is displayed, and the user can't toggle to/from the beta.

How to test 🧪

pnpm run cy:run -s /cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai added the ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration label Jun 5, 2025
@pmakode-akamai pmakode-akamai changed the title tests [M3-10071_aclpIntegration_smokeTests tests: [M3-10071] - aclpIntegration smokeTests Jun 5, 2025
@dmcintyr-akamai dmcintyr-akamai changed the title tests: [M3-10071] - aclpIntegration smokeTests tests: [M3-10071] - aclpBetaServices smokeTests Jun 16, 2025
@dmcintyr-akamai dmcintyr-akamai marked this pull request as ready for review June 16, 2025 18:15
@dmcintyr-akamai dmcintyr-akamai requested review from a team as code owners June 16, 2025 18:15
@dmcintyr-akamai dmcintyr-akamai requested review from cliu-akamai, coliu-akamai and pmakode-akamai and removed request for a team June 16, 2025 18:15
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed tests pass

thanks @dmcintyr-akamai!

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Jun 18, 2025
dmcintyr-akamai and others added 2 commits June 20, 2025 10:38
…bled.spec.ts

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
…bled.spec.ts

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
@coliu-akamai
Copy link
Contributor

heads up, looks like there's a type error in feature-flag-disabled.spec.ts that led to the test file being unable to run now

@dmcintyr-akamai
Copy link
Contributor Author

Failing integratin test passes for me now. And typechecking has no errors as well.

@dmcintyr-akamai
Copy link
Contributor Author

heads up, looks like there's a type error in feature-flag-disabled.spec.ts that led to the test file being unable to run now

fixed

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmcintyr-akamai! The tests look great and are passing reliably for me 👍

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 2, 2025
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side note: We will soon deprecate/remove the isAclpAlertsBeta flag from ManagerPreferences in upcoming PRs, as the requirements for Alerts preferences have changed (we'll be using local state instead of relying on the account-level userPreferences for Alerts). We may need to revisit and update these tests accordingly. More details are provided in ticket M3-10153. (isAclpMetricsBeta will remain as is though)

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #33 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing674 Passing4 Skipped134m 29s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on » LKE Cluster Creation with LKE-E→shows the LKE-E flow with the feature flag on

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts"

@dmcintyr-akamai dmcintyr-akamai merged commit a5634dd into linode:develop Jul 3, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 3, 2025
@pmakode-akamai pmakode-akamai removed the Add'tl Approval Needed Waiting on another approval! label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration Testing

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants