tests: [M3-10071] - aclpBetaServices smokeTests#12310
tests: [M3-10071] - aclpBetaServices smokeTests#12310dmcintyr-akamai merged 35 commits intolinode:developfrom
Conversation
…en varying user preferences
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ confirmed tests pass
thanks @dmcintyr-akamai!
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Outdated
Show resolved
Hide resolved
…bled.spec.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
…bled.spec.ts Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
|
heads up, looks like there's a type error in |
…anager into M3-10071_ff_smokeTests
|
Failing integratin test passes for me now. And typechecking has no errors as well. |
fixed |
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @dmcintyr-akamai! The tests look great and are passing reliably for me 👍
pmakode-akamai
left a comment
There was a problem hiding this comment.
Just a side note: We will soon deprecate/remove the isAclpAlertsBeta flag from ManagerPreferences in upcoming PRs, as the requirements for Alerts preferences have changed (we'll be using local state instead of relying on the account-level userPreferences for Alerts). We may need to revisit and update these tests accordingly. More details are provided in ticket M3-10153. (isAclpMetricsBeta will remain as is though)
Cloud Manager UI test results🔺 1 failing test on test run #33 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts" |
|||||||||||||||||
Description 📝
Verify that the upgrade/downgrade banner is not visible when the aclpBetaServices.alerts or aclpBetaServices.metrics feature flag is disabled, regardless of what the user preference is.
Changes 🔄
4 new tests:
In each of these tests no upgrade or downgrade banner is displayed, and the user can't toggle to/from the beta.
How to test 🧪
pnpm run cy:run -s /cypress/e2e/core/cloudpulse/feature-flag-disabled.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅