Skip to content

upcoming: [M3-10233] – Support NodeBalancer Dual Stack Support feature flag#12420

Merged
harsh-akamai merged 3 commits intolinode:developfrom
harsh-akamai:M3-10233-nb-dual-stack-feature-flag
Jun 30, 2025
Merged

upcoming: [M3-10233] – Support NodeBalancer Dual Stack Support feature flag#12420
harsh-akamai merged 3 commits intolinode:developfrom
harsh-akamai:M3-10233-nb-dual-stack-feature-flag

Conversation

@harsh-akamai
Copy link
Contributor

Description 📝

Create a boolean feature flag for NodeBalancer Dual Stack Support and support it in Cloud

Changes 🔄

  • NodeBalancer Dual Stack feature flag toggle added to our dev tool

How to test 🧪

Verification steps

  • Confirm a toggle for "NodeBalancer Dual Stack Support" is present in our dev tool
  • (optional) Filter network requests for "LaunchDarkly" and observe the presence of a "nodebalancerIpv6" object that has a false value
    image
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai marked this pull request as ready for review June 24, 2025 07:31
@harsh-akamai harsh-akamai requested a review from a team as a code owner June 24, 2025 07:31
@harsh-akamai harsh-akamai requested review from hasyed-akamai and mjac0bs and removed request for a team June 24, 2025 07:31
@harsh-akamai harsh-akamai self-assigned this Jun 24, 2025
@harsh-akamai harsh-akamai added the NB Dual Stack (IPv6) Relating to NodeBalancer Dual Stack Support label Jun 24, 2025
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed flag is returned from LD and is present in our dev tool flag list.
Screenshot 2025-06-24 at 8 56 41 AM

  • Do you foresee any reason why this would be better as a JSON feature flag (e.g. separate LA and GA launches)?
  • Can we please add this flag name to the project tracker?
  • I have one suggestion about consistency in the flag name vs dev tools listed name.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing660 Passing5 Skipped123m 43s

Details

Failing Tests
SpecTest
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jun 25, 2025
@harsh-akamai harsh-akamai merged commit f519036 into linode:develop Jun 30, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NB Dual Stack (IPv6) Relating to NodeBalancer Dual Stack Support

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants