test [M3-10073]: Linode alerts tab based on region and user preference#12442
Closed
dmcintyr-akamai wants to merge 24 commits intolinode:developfrom
Closed
test [M3-10073]: Linode alerts tab based on region and user preference#12442dmcintyr-akamai wants to merge 24 commits intolinode:developfrom
dmcintyr-akamai wants to merge 24 commits intolinode:developfrom
Conversation
pmakode-akamai
added
ACLP Integration
…nager into M3-10073_alerts_prefs
Contributor
Author
|
only test failure is in cypress/e2e/core/kubernetes/lke-create.spec.ts but i didn't touch this file in this PR so i doubt it's related to my code |
dmcintyr-akamai
requested review from
jdamore-linode
and removed request for
a team
dmcintyr-akamai
requested review from
coliu-akamai and
hana-akamai
and removed request for
a team
coliu-akamai
approved these changes
Jul 7, 2025
packages/manager/cypress/e2e/core/linodes/linode-alerts.spec.ts
Outdated
Show resolved
Hide resolved
hana-akamai
reviewed
Jul 9, 2025
| '@getUserPreferences', | ||
| ]); | ||
| ui.tabList.findTabByTitle('Alerts').within(() => { | ||
| cy.get('[data-testid="betaChip"]').should('be.visible'); |
Contributor
There was a problem hiding this comment.
I ran into a failure locally for the betachip line
Collaborator
Cloud Manager UI test results🔺 3 failing tests on test run #15 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/domains/smoke-clone-domain.spec.ts,cypress/e2e/core/account/account-maintenance.spec.ts" |
|||||||||||||||||||||||
hana-akamai
approved these changes
Jul 14, 2025
hana-akamai
added
Approved
4 tasks
Contributor
Author
|
this pr closed bc the test setup changed too much, so i created new pr #12511 |
4 tasks
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR combines the solutions for both M3-10072 and M3-10073, bc the bulk of the setup is for a region being enabled vs disabled for alert support. So the tests are organized by region being enabled/disabled, then by isAclpAlertsBeta value.
Changes 🔄
Region supports alerts
Region does not support alerts
How to test 🧪
pnpm run test packages/manager/cypress/e2e/core/linodes/linode-alerts.spec.ts
Prerequisites
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅