upcoming: [DPS-33118] - Add stream summary#12451
Merged
jaalah-akamai merged 1 commit intolinode:developfrom Jul 3, 2025
Merged
upcoming: [DPS-33118] - Add stream summary#12451jaalah-akamai merged 1 commit intolinode:developfrom
jaalah-akamai merged 1 commit intolinode:developfrom
Conversation
kagora-akamai
force-pushed
the
feature/DPS-33118-add-stream-summary
branch
from
fe9a0f9 to
08b4610
Compare
skrol-akamai
reviewed
Jul 2, 2025
skrol-akamai
reviewed
Jul 2, 2025
packages/manager/src/features/DataStream/dataStreamUtils.test.ts
Outdated
Show resolved
Hide resolved
kagora-akamai
force-pushed
the
feature/DPS-33118-add-stream-summary
branch
from
08b4610 to
75a4825
Compare
kagora-akamai
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
bnussman-akamai
approved these changes
Jul 2, 2025
Comment on lines
19
to
29
| React.useEffect(() => { | ||
| const ignoreFormFields = ['label', 'destination_label']; | ||
|
|
||
| const { unsubscribe } = watch((_, { name }) => { | ||
| if (!ignoreFormFields.includes(name as string)) { | ||
| // eslint-disable-next-line sonarjs/pseudo-random | ||
| setPrice(Math.random() * 100); | ||
| } | ||
| }); | ||
| return () => unsubscribe(); | ||
| }, [watch]); |
Member
There was a problem hiding this comment.
nit (not-blocking): From my understanding, watch will cause the entire from to re-render. Might not be an issue, just something to watch out for
I know this code is not final, but here's what this code could look like in the future:
const { control } = useFormContext<CreateStreamForm>();
const [destinationType] = useWatch({ control, name: ['destination_type'] });
const price = getPrice(destinationType)- We can use
useWatchoverwatchto keep re-renders isolated to this component - We can eliminate the
pricestate and just use aconstthat derives the price from watched form values
Contributor
Author
There was a problem hiding this comment.
Thank You, I checked the watch vs useWatch case. You are right. It looks better now. I adapted the changes so it will not get lost in the future.
cpathipa
approved these changes
Jul 2, 2025
Comment on lines
8
to
9
| fontSize: '16px', | ||
| lineHeight: '22px', |
Contributor
There was a problem hiding this comment.
Can we use design tokens here ?
Contributor
Author
There was a problem hiding this comment.
Yes, thank You. I changed it to use theme.tokens.
kagora-akamai
force-pushed
the
feature/DPS-33118-add-stream-summary
branch
from
75a4825 to
0b0a205
Compare
kagora-akamai
force-pushed
the
feature/DPS-33118-add-stream-summary
branch
from
0b0a205 to
e442d4d
Compare
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts" |
|||||||||||||||||
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
DataStream: Stream Summary checkout bar
Changes 🔄
NameandDestination Namefields)Target release date 🗓️
July 2025
Preview 📷
How to test 🧪
Prerequisites
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅