fix: [M3-10273] - Unexpected Linode Create deep link behavior#12457
Merged
bnussman-akamai merged 6 commits intolinode:developfrom Jul 2, 2025
Conversation
bnussman-akamai
changed the title
bnussman-akamai
requested review from
coliu-akamai,
hana-akamai and
mjac0bs
and removed request for
a team
bnussman-akamai
commented
Jul 1, 2025
packages/manager/src/features/Linodes/LinodeCreate/shared/LinodeSelectTable.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| // Get the default values for the new tab and reset the form | ||
| defaultValues({ ...params, type: newTab }, queryClient, { | ||
| defaultValues(newParams, queryClient, { |
Member
Author
There was a problem hiding this comment.
When switching tab, I'm pretty sure we don't want to factor in the old search params. Not sure why I had this spread here
| subtype: params.subtype ?? undefined, | ||
| type: params.type ?? undefined, | ||
| }), | ||
| search: params, |
Member
Author
There was a problem hiding this comment.
Small oversight originating from the Linode TanStack router changes.
setParams should override params, but updateParams above should just update them/merge the changed params.
| updateParams({ | ||
| stackScriptID: undefined, | ||
| subtype: tabs[index], | ||
| type: 'StackScripts', |
Member
Author
There was a problem hiding this comment.
This is unnecessary. The type param will already be StackScripts so there is no need to set it again
hana-akamai
approved these changes
Jul 2, 2025
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts" |
||||||||||||||||||||
mjac0bs
added
Approved
coliu-akamai
approved these changes
Jul 2, 2025
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ confirmed deep link fixes
thank you!
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Screen.Recording.2025-07-01.at.5.16.31.PM.mov
Screen.Recording.2025-07-01.at.5.17.18.PM.mov
How to test 🧪
Prerequisites
Verification steps
?type=BackupsAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅