Skip to content

fix: [DI-26001] - Fix inconsistent gap in dimension filter and metric #12475

Merged
nikhagra-akamai merged 6 commits intolinode:developfrom
santoshp210-akamai:feature/alert-dimension-grid-spacing
Jul 9, 2025
Merged

fix: [DI-26001] - Fix inconsistent gap in dimension filter and metric #12475
nikhagra-akamai merged 6 commits intolinode:developfrom
santoshp210-akamai:feature/alert-dimension-grid-spacing

Conversation

@santoshp210-akamai
Copy link
Contributor

Description 📝

Fixed the spacing and widths for dimension filters and metric to be consistent.

Changes 🔄

  • Changed the gap to spacing in the Grid component in DimensionFilterField.
  • Removed the unneccessary Box component in Metric .
  • Added a flexWrap to the Grid component in DimensionFilterField.

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2025-07-01 at 17 20 46 image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Under Monitor, select Alerts. Click on Create Alert button to view the form.

Verification steps

  • The width of the Data Field for Metric and Dimension Filter should be the same.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai santoshp210-akamai requested a review from a team as a code owner July 4, 2025 05:57
@santoshp210-akamai santoshp210-akamai requested review from hana-akamai and pmakode-akamai and removed request for a team July 4, 2025 05:57
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-09 at 11 52 46 AM

The width of the Data Field for Metric and Dimension Filters doesn’t look the same across different screen sizes (especially for screen sizes < lg)

@nikhagra-akamai
Copy link
Contributor

The width of the Data Field for Metric and Dimension Filters doesn’t look the same across different screen sizes

Its okay because in metrics we have 4 filters where in dimensions we have 3 & widths are also different as per UX

@pmakode-akamai pmakode-akamai self-requested a review July 9, 2025 07:21
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 9, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 676 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing676 Passing4 Skipped118m 4s

@nikhagra-akamai nikhagra-akamai merged commit 3b1bf09 into linode:develop Jul 9, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants