Skip to content

fix: [M3-10289] - Enhance Devtools to support aclpBetaServices nested Feature flags#12478

Merged
jaalah-akamai merged 4 commits intolinode:developfrom
pmakode-akamai:M3-10289-enhance-devtools-to-support-aclpbetaservices-nested-flags
Jul 7, 2025
Merged

fix: [M3-10289] - Enhance Devtools to support aclpBetaServices nested Feature flags#12478
jaalah-akamai merged 4 commits intolinode:developfrom
pmakode-akamai:M3-10289-enhance-devtools-to-support-aclpbetaservices-nested-flags

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 4, 2025

Description 📝

Devtools currently supports toggling only 0 and 1-level feature flags. With the recent addition of 2-level nested flags (for eg., aclpBetaServices.ServiceType.flagName) under aclpBetaServices, the toggling is not working as expected.

This update should fix the current behavior and support setting nested flags at any depth recursively to ensure correct behavior.

Changes 🔄

  • Updated feature flag toggling to support recursive toggling at any depth, instead of being limited to root (0-level) and 1-level flags

Target release date 🗓️

N/A

Preview 📷

Before After
Screen.Recording.2025-07-07.at.11.31.39.AM.mov
Screen.Recording.2025-07-07.at.11.24.22.AM.mov

How to test 🧪

Prerequisites

  • The Alerts section under Additional Options in the Create Linode flow is only visible for ACLP-supported regions (e.g., US, Washington DC) and when the aclpBetaServices.linode.alerts feature flag is enabled

Reproduction steps

  • Follow the steps in the attached video ("Before")

Verification steps

  • Devtools should continue to work as expected for 0-level and 1-level feature flags
  • Devtools should support toggling and saving 2-level nested flags (e.g., aclpBetaServices.ServiceType.flagName)
  • All toggled feature flags should be correctly reflected in Local Storage and UI
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai changed the title change: [M3-10289] - Enhance Devtools to support aclpBetaServices nested Feature flags fix: [M3-10289] - Enhance Devtools to support aclpBetaServices nested Feature flags Jul 7, 2025
@pmakode-akamai pmakode-akamai added the ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration label Jul 7, 2025
@pmakode-akamai pmakode-akamai marked this pull request as ready for review July 7, 2025 06:30
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 7, 2025 06:30
@pmakode-akamai pmakode-akamai requested review from cpathipa, harsh-akamai and jaalah-akamai and removed request for a team July 7, 2025 06:30
@pmakode-akamai pmakode-akamai added the Bug Fixes for regressions or bugs label Jul 7, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 675 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing675 Passing4 Skipped125m 13s

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 7, 2025
@jaalah-akamai jaalah-akamai merged commit 58ccb60 into linode:develop Jul 7, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 7, 2025
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Enhancement

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants