upcoming: [DI-26180] - Added VPC Subnet filter component for cloudpulse#12489
upcoming: [DI-26180] - Added VPC Subnet filter component for cloudpulse#12489nikhagra-akamai merged 14 commits intolinode:developfrom
Conversation
nikhagra-akamai
requested review from
cpathipa and
mjac0bs
and removed request for
a team
| textFieldProps={{ | ||
| InputProps: { | ||
| sx: { | ||
| '::-webkit-scrollbar': { | ||
| display: 'none', | ||
| }, | ||
| maxHeight: '55px', | ||
| msOverflowStyle: 'none', | ||
| overflow: 'auto', | ||
| scrollbarWidth: 'none', | ||
| }, | ||
| }, | ||
| }} |
There was a problem hiding this comment.
Is all of the one-off styling necessary? I think we should leave these things alone and, if we need to handle them, do them app-wide using our themeing
There was a problem hiding this comment.
This was done to keep autocomplete scrollable after certain height for multi select otherwise the input box's height will increase alot
There was a problem hiding this comment.
@nikhagra-akamai I see; you're talking about this:
Screen.Recording.2025-07-14.at.10.17.56.AM.mov
I don't think that scrolling within the textfield is the UX we want here - it's not very discoverable by the user and introduces some inconsistencies with how we handle many selected options elsewhere in the app (see the image select in the attached video).
Screen.Recording.2025-07-14.at.10.14.36.AM.mov
The input box's height will increase temporarily while the options dropdown is open, but it returns to normal size once the user clicks out of it. Can we remove these styles and keep current behavior?
There was a problem hiding this comment.
I've removed the styling for now.
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks Nikhil. Approving pending the comment about textfieldProps styling is addressed.
packages/manager/src/features/CloudPulse/Utils/CloudPulseVPCSubnet.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🎉 676 passing tests on test run #8 ↗︎
|
mjac0bs
added
Approved
5 participants
Description 📝
Added a VPC subnet filter component for cloudpulse
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
29th July
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅