-
Notifications
You must be signed in to change notification settings - Fork 390
change: [DI-26188] - Updated Alert Reusable component based on the latest mockup #12549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [DI-26188] - Updated Alert Reusable component based on the latest mockup #12549
Conversation
…give outline to cancel button
…tual_view_enhancement
| <Box display="flex" justifyContent="space-between"> | ||
| <Box alignItems="center" display="flex" gap={0.5}> | ||
| <Typography variant="h2">Alerts</Typography> | ||
| <BetaChip /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): Variable chip for different phases
As a separate effort, we may want to conditionally render either the beta or new feature chip based on LD flag. Maybe we can move/re-use this util throughout the app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point, beta chip will vary based on the phase. Will update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the flag in LD to integrate this, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to show beta chip according to aclpBetaServices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: I believe we want to swap the Beta chip with the New feature chip for the GA rollout. We may also need to update the LD flag structure for alerts (and possibly other features) to allow hiding the Beta chip even when the feature flag is enabled.
something like this:
{
...
alerts: {
enabled: boolean;
beta: boolean;
new: boolean;
},
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not finalized yet to show new feature chip. Will take it later. Currently it'll just toggle to show or hide beta chip
|
@pmakode-akamai pls review & Provide second approval |
…ra-akamai/manager into alert/contextual_view_enhancement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pass isLegacyAlertAvailable={!isLinodeAclpSubscribed} to the AclpReusabledComponent here at /LinodesDetail/LinodeAlerts/LinodeAlerts.tsx#L45 in this PR itself, or should we handle it in a separate PR?
edit: Addressed in d33d48b ✅
packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertReusableComponent.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/CloudPulse/Alerts/ContextualView/AlertInformationActionTable.tsx
Show resolved
Hide resolved
…ra-akamai/manager into alert/contextual_view_enhancement
pmakode-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (blocking): Now that we have some beta alerts enabled by default, I noticed that in the create flow, service owners don’t have access to the default enabled beta alerts state until they toggle one of the alert options (for eg., updatedAlerts from handleToggleAlert), I'm wondering how we can ensure these alerts are enabled in the default state without requiring user interaction
Screen.Recording.2025-07-23.at.3.04.04.PM.mov
…itial render of table
…tual_view_enhancement
@pmakode-akamai I've updated the logic to handle initial state Screen.Recording.2025-07-23.at.5.02.56.PM.mov |
Cloud Manager UI test results🎉 690 passing tests on test run #8 ↗︎
|
pmakode-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅
Thanks for making the changes and fixing the initial state logic!
|
Missed to add the changeset, hence added in this PR |
Description 📝
Updated Alert Reusable component based on the latest mockup
https://www.figma.com/design/uvdOz9Xs0RVdMRJMCIgS9H/ACLP---Contextual-views?node-id=13721-11625&t=fXEAT02sleQcIKkQ-0
Changes 🔄
List any change(s) relevant to the reviewer.
onToggleAlertto be used in both create and edit mode to serve different use casesTarget release date 🗓️
12th August
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅