-
Notifications
You must be signed in to change notification settings - Fork 390
upcoming: [M3-10201] - Add BYO VPC support to LKE cluster create flow #12551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-10201] - Add BYO VPC support to LKE cluster create flow #12551
Conversation
d1e50ca to
0061ee3
Compare
0061ee3 to
37bc470
Compare
…beClusterPayload for LKE-E
| )} | ||
| /> | ||
| </Stack> | ||
| <Stack divider={<Divider />} spacing={3}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removed the fragment here; no other changes to the IP Version radio group.
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Show resolved
Hide resolved
I'm briefly seeing the client-side validation but the request to create is still going through 🤔 Screen.Recording.2025-08-04.at.5.28.38.PM.mov |
|
@hana-akamai Is it the same behavior if you have the Edit: Okay, yep, I can repro. No relation to |
|
@hana-akamai Thank you - that error should actually block form submission and be scrolled to now. (b40576b) Screen.Recording.2025-08-04.at.3.01.39.PM.mov |
Cloud Manager UI test results🔺 3 failing tests on test run #14 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts" |
|||||||||||||||||||||||
Description 📝
The Networking section of the cluster create flow (formerly "VPC & Firewall") is getting new options to support the user's selection of VPC.
Note
Changes 🔄
ClusterNetworkingPanel.tsxwith radio buttons to support an auto-generation option and a Bring-Your-Own (BYO) VPC optionvpc_id,subnet_id)ClusterNetworkingPanelTarget release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
enabled,LA, andphase2Mtcshould all be checked)Verification steps
(How to verify changes)
LKE-E:
Automatically generate a VPC for this clusterkubernetes.tshandlers POST /v4beta/clusters request and observe the error responses on the VPC and Subnet fields are surfaced./v4beta/clustersincludes the expected data in the payload.vpc_idis present,subnet_idis notvpc_idandsubnet_idis presentvpc_idorsubnet_idare presentLKE:
/v4beta/clustersdoes not includevpc_idorsubnet_idin the payloadFeature flag:
phase2Mtcfeature flag and confirm you see the existing "VPC & Firewall" section for enterprise onlyTests:
pnpm test ClusterNetworkingPanelpassesAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅