-
Notifications
You must be signed in to change notification settings - Fork 390
feat: [M3-10361] - Use Search v2 to power the Volumes Landing page #12553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-10361] - Use Search v2 to power the Volumes Landing page #12553
Conversation
Cloud Manager UI test results🎉 690 passing tests on test run #5 ↗︎
|
harsh-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @bnussman-akamai! 🚀
✅ Verify search is debounced
✅ Verify you can search by label
✅ Verify you can search by size: size > 10 or you can search by a combination of things: region = us-mia or size >= 11
✅ Verify the page gracefully errors if you type an invalid query like banks = test
Description 📝
size > 10region = us-miatag: stagingregion = us-mia or size >= 11DebouncedSearchTextFieldcomponent rather than a one-offTextFieldso that the UI better aligns with the Akamai Design SystemPreview 📷
DebouncedSearchTextFieldcomponent is now used instead of a simpleTextFieldComplex Queries are now supported 🎉
How to test 🧪
Prerequisites
Verification steps
/volumessize > 10region = us-miatag: stagingregion = us-mia or size >= 11banks = testAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅