chore: [M3-10368] - Use DebouncedSearchTextField on Images Landing
#12555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
coliu-akamai and
hana-akamai
and removed request for
a team
bnussman-akamai
changed the title
DebouncedSearchTextField on Images Landing
bnussman-akamai
changed the title
DebouncedSearchTextField on Images LandingDebouncedSearchTextField on Images Landing
bnussman-akamai
added
the
Related Cypress Test Failure
bnussman-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
…a classic Text field
bnussman-akamai
commented
Jul 23, 2025
Member
Author
There was a problem hiding this comment.
While I was here, I updated the unit tests to not mock as much and to use other best practices.
Comment on lines
-370
to
-374
| history.push({ | ||
| pathname: `/linodes/create/`, | ||
| search: `?type=Images&imageID=${imageId}`, | ||
| }); | ||
| }; |
Member
Author
There was a problem hiding this comment.
I replacted this react-router-dom call with a TanStack router call. This is safe to do now because Linodes now use TanStack router
| rerender: (ui) => utils.rerender(wrapWithTheme(ui, options)), | ||
| rerender: (ui: React.ReactNode) => | ||
| utils.rerender(wrapWithTheme(ui, { ...options, router })), | ||
| router, |
Member
Author
There was a problem hiding this comment.
Allows us to make assertions based on the router's state.
bnussman-akamai
removed
the
Related Cypress Test Failure
hana-akamai
approved these changes
Jul 23, 2025
Contributor
hana-akamai
left a comment
hana-akamai
left a comment
There was a problem hiding this comment.
No regressions noticed ✅
hana-akamai
added
Images
Collaborator
Cloud Manager UI test results🎉 690 passing tests on test run #7 ↗︎
|
coliu-akamai
approved these changes
Jul 24, 2025
Contributor
coliu-akamai
left a comment
coliu-akamai
left a comment
There was a problem hiding this comment.
✅ search and debounce
thanks @bnussman-akamai!
coliu-akamai
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
DebouncedSearchTextFieldon the Images landing page insted of a one-offTextFieldcomponent 🔍Preview 📷
How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅