feat: [UIE-8999] - IAM RBAC Adjust the parameters to useQueryWithPermissions and return errors #12560

corya-akamai · 2025-07-23T14:06:41Z

Description 📝

Modified the query parameter to allow varying use cases. Return any errors from the API along with isLoading, isError values.

Changes 🔄

List any change(s) relevant to the reviewer.

Modified the query parameter to allow varying use cases
Return any errors from the API along with isLoading, isError values.

Target release date 🗓️

8/12

Preview 📷

Restricted non-beta (Grants)

Restricted beta (Permissions)

Unrestricted non-beta (Grants)

Unrestricted beta (Permissions)

How to test 🧪

Prerequisites

devcloud IAM account unrestricted user
devcloud IAM account restricted user

Reproduction steps

http://localhost:3000/linodes/{instancedId}/backup
Click "Restore to Existing Linode"
Click Linode drope down in drawer

Verification steps

Unrestricted user has access to all lindoes non-beta
Unrestricted user has access to all lindoes beta
Rrestricted user has access to a limited set of lindoes non-beta
Rrestricted user has access to a limited set of lindoes beta

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

packages/manager/src/features/IAM/hooks/usePermissions.ts

coliu-akamai

Just wanted to double check testing setup to make sure I'm understanding everything correctly: I created a new user for myself on the iam account with limited permissions.

should I be using IAM and the users & roles tab to update my limited account's viewable entities?
Can I also use the grants model on this account, or should I have a separate, non-iam related restricted account to test on?

packages/manager/src/features/IAM/hooks/usePermissions.ts

corya-akamai · 2025-07-23T20:25:19Z

Just wanted to double check testing setup to make sure I'm understanding everything correctly: I created a new user for myself on the iam account with limited permissions.

should I be using IAM and the users & roles tab to update my limited account's viewable entities?

Can I also use the grants model on this account, or should I have a separate, non-iam related restricted account to test on?

@coliu-akamai , Yes you can use the grants model on the same IAM account. Just turn the IAM flag off.

kwojtowiakamai · 2025-07-28T10:26:27Z

In both the Create Firewall and Restore Backup drawers:
✅ Dropdown options are correctly displayed based on the permissions/grants for both IAM and non-IAM users.
✅ Loading state works correctly.
✅ Error state works correctly.

kwojtowiakamai · 2025-07-28T10:58:35Z

I found one edge case, but I don't know if this scenario is possible without using devtools. The page shows TypeError: Cannot read properties of undefined (reading 'update_linode')

Steps to reproduce:

The user has only the account_linode_admin role assigned.
Log in as the user to CM and go to http://localhost:3000/linodes/{linode_id}/backup.
Disable the Identity and Access Beta feature flag in the devtools.
Click the Restore to Existing Linode option for the backup entity.

Screen.Recording.2025-07-28.at.12.45.18.PM2.mov

dwiley-akamai

Observed the described options for unrestricted & restricted users w/ beta on and off ✅
Code review ✅

Could consider adding some test assertions in RestoreToLinodeDrawer.test.tsx to cover the different scenarios and see if the expected options are displayed

dwiley-akamai · 2025-07-28T21:30:30Z

packages/manager/.changeset/pr-12560-upcoming-features-1753279716756.md

+"@linode/manager": Upcoming Features
+---
+
+Modified the query parameter to allow varying use cases. Return any errors from the API along with isLoading, isError values. ([#12560](https://github.com/linode/manager/pull/12560))


Suggested change

Modified the query parameter to allow varying use cases. Return any errors from the API along with isLoading, isError values. ([#12560](https://github.com/linode/manager/pull/12560))

IAM RBAC: Modified query parameter to allow varying use cases, return API errors, and return isLoading and isError values ([#12560](https://github.com/linode/manager/pull/12560))

coliu-akamai

ahh right 🤦‍♀️ thanks @corya-akamai!

✅ confirmed the four scenarios

…sion hook, return errors and loading indicators

linode-gh-bot · 2025-07-30T15:36:17Z

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`3 Failing`	`698 Passing`	`4 Skipped`	`134m 20s`

Details

Failing Tests
	Spec	Test
❌	`lke-create.spec.ts`	Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
❌	`lke-create.spec.ts`	Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
❌	`lke-create.spec.ts`	Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts"

corya-akamai · 2025-07-30T17:59:32Z

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

❌ Failing ✅ Passing ↪️ Skipped 🕐 Duration
3 Failing 698 Passing 4 Skipped 134m 20s

Details

Failing Tests
Spec Test
❌ lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
❌ lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
❌ lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability

Troubleshooting

Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts"

#12561 (comment)

corya-akamai requested a review from a team as a code owner July 23, 2025 14:06

corya-akamai requested review from coliu-akamai and dwiley-akamai and removed request for a team July 23, 2025 14:06

github-project-automation bot added this to Cloud Manager Jul 23, 2025

github-project-automation bot moved this to Review in Cloud Manager Jul 23, 2025

corya-akamai added 🚨 Urgent Linodes Dealing with the Linodes section of the app IAM (Identity & Access Management) Firewalls Related to Firewalls labels Jul 23, 2025

mjac0bs assigned corya-akamai Jul 23, 2025

jaalah-akamai reviewed Jul 23, 2025

View reviewed changes

packages/manager/src/features/IAM/hooks/usePermissions.ts Show resolved Hide resolved

coliu-akamai reviewed Jul 23, 2025

View reviewed changes

corya-akamai removed the 🚨 Urgent label Jul 23, 2025

jaalah-akamai reviewed Jul 23, 2025

View reviewed changes

packages/manager/src/features/IAM/hooks/usePermissions.ts Outdated Show resolved Hide resolved

packages/manager/src/features/IAM/hooks/usePermissions.ts Show resolved Hide resolved

packages/manager/src/features/IAM/hooks/usePermissions.ts Show resolved Hide resolved

linode deleted a comment from linode-gh-bot Jul 23, 2025

kwojtowiakamai approved these changes Jul 28, 2025

View reviewed changes

corya-akamai requested review from coliu-akamai and jaalah-akamai July 28, 2025 14:05

dwiley-akamai approved these changes Jul 28, 2025

View reviewed changes

coliu-akamai approved these changes Jul 29, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 29, 2025

coliu-akamai added the Approved Multiple approvals and ready to merge! label Jul 29, 2025

Conal Ryan added 3 commits July 30, 2025 08:20

feat: [UIE-8999] - IAM RBAC add parameters to the userQueryWithPermis…

66df574

…sion hook, return errors and loading indicators

Changeset

7cd93f8

Better API

adc698f

corya-akamai force-pushed the UIE-8999-useQueryWithPermissions branch from 54a6dfb to adc698f Compare July 30, 2025 12:21

Fix test

86ab41c

corya-akamai merged commit 9983af1 into linode:develop Jul 30, 2025
34 of 35 checks passed

corya-akamai deleted the UIE-8999-useQueryWithPermissions branch July 30, 2025 17:59

github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 30, 2025

jaalah-akamai mentioned this pull request Aug 6, 2025

Release v1.148.0 - release → staging #12652

Merged

bnussman-akamai mentioned this pull request Aug 8, 2025

Release v1.148.0 - staging → master #12662

Merged

	Modified the query parameter to allow varying use cases. Return any errors from the API along with isLoading, isError values. ([#12560](https://github.com/linode/manager/pull/12560))
	IAM RBAC: Modified query parameter to allow varying use cases, return API errors, and return isLoading and isError values ([#12560](https://github.com/linode/manager/pull/12560))

feat: [UIE-8999] - IAM RBAC Adjust the parameters to useQueryWithPermissions and return errors #12560

feat: [UIE-8999] - IAM RBAC Adjust the parameters to useQueryWithPermissions and return errors #12560

Uh oh!

Conversation

corya-akamai commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

corya-akamai commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwojtowiakamai commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwojtowiakamai commented Jul 28, 2025

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Jul 30, 2025

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

Details

Troubleshooting

Uh oh!

corya-akamai commented Jul 30, 2025

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

corya-akamai commented Jul 23, 2025 •

edited

Loading

corya-akamai commented Jul 23, 2025 •

edited

Loading

kwojtowiakamai commented Jul 28, 2025 •

edited

Loading