Skip to content

Conversation

@harsh-akamai
Copy link
Contributor

@harsh-akamai harsh-akamai commented Jul 24, 2025

Description 📝

Update styles to match ADS for Link component

Changes 🔄

  • Update the DocsIcon and ExternalLinkIcon
  • Update the colors for Link

Preview 📷

Before After
Dark Theme image image
Light Theme image image

How to test 🧪

Verification steps

(How to verify changes)

  • Verify the updated sytles match with the figma mockups
  • Verify consistent appearance and behavior in both light and dark modes
  • Ensure no UI or layout regressions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai self-assigned this Jul 24, 2025
@harsh-akamai harsh-akamai added Design Tokens Laying the groundwork for Design Tokens Requires UX Approval Design System Component Requires UX Approval labels Jul 24, 2025
@harsh-akamai harsh-akamai marked this pull request as ready for review July 25, 2025 08:04
@harsh-akamai harsh-akamai requested a review from a team as a code owner July 25, 2025 08:04
@harsh-akamai harsh-akamai requested review from dwiley-akamai and hasyed-akamai and removed request for a team July 25, 2025 08:04
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appearance & behavior ✅
Styles match ✅
No UI regressions observed ✅

@harsh-akamai
Copy link
Contributor Author

@tzmiivsk-akamai feel free to add your review as I'm not able to add you to the reviewer's list

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 28, 2025
@hasyed-akamai hasyed-akamai added the Approved Multiple approvals and ready to merge! label Jul 28, 2025
@tzmiivsk-akamai
Copy link

Hi,
I see that the icon is broken, which is probably why the spacing between the icon and the label looks wrong.
Also, the external link icon is not updated, e.g., in Kubernetes.

image image

@tzmiivsk-akamai
Copy link

Please see the right example:
image

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing689 Passing4 Skipped127m 24s

Details

Failing Tests
SpecTest
timerange-verification.spec.tsCloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » Integration tests for verifying Cloudpulse custom and preset configurations

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

@tzmiivsk-akamai
Copy link

Approved

@harsh-akamai harsh-akamai merged commit 5cd604a into linode:develop Jul 29, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 29, 2025
@harsh-akamai harsh-akamai deleted the M3-10097-ads-link-component branch July 29, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens Requires UX Approval Design System Component Requires UX Approval

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants