test: [M3-8559] - Increase Security.test.tsx waitFor timeout from 1s to 5s
#12576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
bnussman-akamai and
mjac0bs
and removed request for
a team
Contributor
Author
|
Ran CI 5 times in a row and didn't observe any failures so it looks like increasing the timeout did the trick here 👍 just pushed a changeset so it and the Cypress tests will run one more time. |
mjac0bs
approved these changes
Jul 24, 2025
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Yay, it passed CI again. Thanks, Joe, for the quick fix. 🚀
bnussman-akamai
added
Approved
Collaborator
Cloud Manager UI test results🎉 690 passing tests on test run #2 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Experimenting to see if increasing the
waitFortimeout resolves the flake in theSecurity.test.tsxspec. If CI passes, I'll kick it off a few more times to confirm it's passing reliably. If not, I'll try increasing the timeout and/or applying the timeout to the entire test.Changes 🔄
waitFortimeout from 1s to 5sTarget release date 🗓️
N/A.
How to test 🧪
It seems like this test is passing locally for most users. Intel Mac users may be able to observe the failure by running the following against
develop:It seems like this test fails most often in CI, so I've run the tests against the PR 5 times and it's passed each time.
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅